Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Gitk fails to open on a bare Git repository on Windows #2549

Merged
merged 1 commit into from
Apr 17, 2020
Merged

[fix] Gitk fails to open on a bare Git repository on Windows #2549

merged 1 commit into from
Apr 17, 2020

Conversation

remybohmer
Copy link

Running 'git rev-parse --show-toplevel' fails on a bare git repo.
This causes gitk to fail to startup.

Signed-off-by: Remy Bohmer github@bohmer.net

@remybohmer
[fix] Gitk fails to open on a bare Git repository on Windows
448b5a9 
Running 'git rev-parse --show-toplevel' fails on a bare git repo.
This causes gitk to fail to startup.

Signed-off-by: Remy Bohmer <github@bohmer.net>
dscho
dscho requested changes Mar 20, 2020
View reviewed changes
Copy link
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I have only minor concerns (which may not even need code changes but only answers to be addressed).

Thank you for opening this PR!

gitk-git/gitk Show resolved Hide resolved
@remybohmer remybohmer requested a review from dscho April 16, 2020 15:16
dscho
dscho approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the prod!

@dscho dscho merged commit a12503a into git-for-windows:master Apr 17, 2020
@dscho dscho added this to the Next release milestone Apr 17, 2020
dscho added a commit that referenced this pull request Apr 17, 2020
@dscho
Merge pull request #2549 from remybohmer/master
e899102 
[fix] Gitk fails to open on a bare Git repository on Windows
dscho added a commit that referenced this pull request Apr 17, 2020
@dscho
Merge pull request #2549 from remybohmer/master
aa8e1a7 
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci pushed a commit that referenced this pull request Apr 17, 2020
@dscho
Merge pull request #2549 from remybohmer/master
8cae0f7 
[fix] Gitk fails to open on a bare Git repository on Windows
dscho added a commit that referenced this pull request Apr 18, 2020
@dscho
Merge pull request #2549 from remybohmer/master
e8cbef3 
[fix] Gitk fails to open on a bare Git repository on Windows
@weekly-digest weekly-digest bot mentioned this pull request Apr 19, 2020
Closed
dscho added a commit to git-for-windows/build-extra that referenced this pull request Apr 20, 2020
@dscho
Mention Bug Fix in release notes
f297942 
A recent regression in `gitk` that prevented
it from running in bare repositories [has been
fixed](git-for-windows/git#2549).

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
git-for-windows-ci pushed a commit that referenced this pull request Apr 20, 2020
@dscho
Merge pull request #2549 from remybohmer/master
0082abc 
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci pushed a commit that referenced this pull request Apr 20, 2020
@dscho
Merge pull request #2549 from remybohmer/master
e8f9b8f 
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci pushed a commit that referenced this pull request Apr 20, 2020
@dscho
Merge pull request #2549 from remybohmer/master
112d9bc 
[fix] Gitk fails to open on a bare Git repository on Windows
derrickstolee pushed a commit to microsoft/git that referenced this pull request Apr 20, 2020
@dscho
Merge pull request git-for-windows#2549 from remybohmer/master
d4d1893 
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci pushed a commit that referenced this pull request Apr 21, 2020
@dscho
Merge pull request #2549 from remybohmer/master
e3b26b0 
[fix] Gitk fails to open on a bare Git repository on Windows
dscho added a commit that referenced this pull request Apr 21, 2020
@dscho
Merge pull request #2549 from remybohmer/master
7d5191e 
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci pushed a commit that referenced this pull request Apr 22, 2020
@dscho
Merge pull request #2549 from remybohmer/master
c41f569 
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci pushed a commit that referenced this pull request Apr 22, 2020
@dscho
Merge pull request #2549 from remybohmer/master
bd02f32 
[fix] Gitk fails to open on a bare Git repository on Windows
dscho added a commit that referenced this pull request Apr 22, 2020
@dscho
Merge pull request #2549 from remybohmer/master
e514235 
[fix] Gitk fails to open on a bare Git repository on Windows
dscho added a commit that referenced this pull request Apr 22, 2020
@dscho
Merge pull request #2549 from remybohmer/master
c4c89ea 
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci pushed a commit that referenced this pull request Sep 25, 2020
@dscho
Merge pull request #2549 from remybohmer/master
d67bc05 
[fix] Gitk fails to open on a bare Git repository on Windows
dscho added a commit that referenced this pull request Sep 25, 2020
@dscho
Merge pull request #2549 from remybohmer/master
1816544 
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci pushed a commit that referenced this pull request Sep 25, 2020
@dscho
Merge pull request #2549 from remybohmer/master
031642c 
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci pushed a commit that referenced this pull request Sep 25, 2020
@dscho
Merge pull request #2549 from remybohmer/master
c6ebe58 
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci pushed a commit that referenced this pull request Sep 25, 2020
@dscho
Merge pull request #2549 from remybohmer/master
ec55c86 
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci pushed a commit that referenced this pull request Sep 27, 2020
@dscho
Merge pull request #2549 from remybohmer/master
45c4342 
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci pushed a commit that referenced this pull request Sep 27, 2020
@dscho
Merge pull request #2549 from remybohmer/master
e7cd0a4 
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci pushed a commit that referenced this pull request Sep 28, 2020
@dscho
Merge pull request #2549 from remybohmer/master
5818653 
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci pushed a commit that referenced this pull request Sep 28, 2020
@dscho
Merge pull request #2549 from remybohmer/master
9be641a 
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci pushed a commit that referenced this pull request Sep 28, 2020
@dscho
Merge pull request #2549 from remybohmer/master
aacd0c5 
[fix] Gitk fails to open on a bare Git repository on Windows
dscho added a commit that referenced this pull request Sep 29, 2020
@dscho
Merge pull request #2549 from remybohmer/master
8801c40 
[fix] Gitk fails to open on a bare Git repository on Windows
dscho added a commit that referenced this pull request Sep 29, 2020
@dscho
Merge pull request #2549 from remybohmer/master
c832896 
[fix] Gitk fails to open on a bare Git repository on Windows
dscho added a commit that referenced this pull request Sep 29, 2020
@dscho
Merge pull request #2549 from remybohmer/master
ffc6b3a 
[fix] Gitk fails to open on a bare Git repository on Windows
dscho added a commit that referenced this pull request Sep 29, 2020
@dscho
Merge pull request #2549 from remybohmer/master
1d69010 
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci pushed a commit that referenced this pull request Sep 29, 2020
@dscho
Merge pull request #2549 from remybohmer/master
54323ed 
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci pushed a commit that referenced this pull request Sep 29, 2020
@dscho
Merge pull request #2549 from remybohmer/master
6d9f404 
[fix] Gitk fails to open on a bare Git repository on Windows
dscho added a commit that referenced this pull request Sep 30, 2020
@dscho
Merge pull request #2549 from remybohmer/master
b581e59 
[fix] Gitk fails to open on a bare Git repository on Windows
dscho added a commit that referenced this pull request Oct 1, 2020
@dscho
Merge pull request #2549 from remybohmer/master
ac782f0 
[fix] Gitk fails to open on a bare Git repository on Windows
dscho added a commit that referenced this pull request Oct 2, 2020
@dscho
Merge pull request #2549 from remybohmer/master
6c6724f 
[fix] Gitk fails to open on a bare Git repository on Windows
dscho added a commit that referenced this pull request Oct 2, 2020
@dscho
Merge pull request #2549 from remybohmer/master
11e9665 
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci pushed a commit that referenced this pull request Oct 2, 2020
@dscho
Merge pull request #2549 from remybohmer/master
f33d892 
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci pushed a commit that referenced this pull request Oct 2, 2020
@dscho
Merge pull request #2549 from remybohmer/master
98ca555 
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci pushed a commit that referenced this pull request Oct 2, 2020
@dscho
Merge pull request #2549 from remybohmer/master
04985b4 
[fix] Gitk fails to open on a bare Git repository on Windows
dscho added a commit that referenced this pull request Oct 2, 2020
@dscho
Merge pull request #2549 from remybohmer/master
98b326b 
[fix] Gitk fails to open on a bare Git repository on Windows
dscho added a commit that referenced this pull request Oct 2, 2020
@dscho
Merge pull request #2549 from remybohmer/master
dbe21be 
[fix] Gitk fails to open on a bare Git repository on Windows
dscho added a commit that referenced this pull request Oct 5, 2020
@dscho
Merge pull request #2549 from remybohmer/master
ff8d9fa 
[fix] Gitk fails to open on a bare Git repository on Windows
dscho added a commit to dscho/git that referenced this pull request Oct 5, 2020
@dscho
Merge pull request git-for-windows#2549 from remybohmer/master
8e2be26 
[fix] Gitk fails to open on a bare Git repository on Windows
dscho added a commit that referenced this pull request Oct 6, 2020
@dscho
Merge pull request #2549 from remybohmer/master
123ac75 
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci pushed a commit that referenced this pull request Oct 7, 2020
@dscho
Merge pull request #2549 from remybohmer/master
15cd4ef 
[fix] Gitk fails to open on a bare Git repository on Windows
dscho added a commit that referenced this pull request Oct 20, 2020
@dscho
Merge pull request #2549 from remybohmer/master
35c9f55 
[fix] Gitk fails to open on a bare Git repository on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dscho dscho dscho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@remybohmer @dscho