Fix review comments

Author: git-hulk

src/ast/data_type.rs

@@ -25,19 +25,19 @@ use serde::{Deserialize, Serialize};
 #[cfg(feature = "visitor")]
 use sqlparser_derive::{Visit, VisitMut};
 
-use crate::ast::{display_comma_separated, ObjectName, StructField, UnionField, Value};
+use crate::ast::{display_comma_separated, Expr, ObjectName, StructField, UnionField};
 
 use super::{value::escape_single_quote_string, ColumnDef};
 
 #[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
 #[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]
-pub enum EnumValue {
-    String(String),
+pub enum EnumMember {
+    Name(String),
     /// ClickHouse allows to specify an integer value for each enum value.
     ///
     /// [clickhouse](https://clickhouse.com/docs/en/sql-reference/data-types/enum)
-    Pair(String, Value),
+    NameValue(String, Expr),
 }
 
 /// SQL data types
@@ -311,7 +311,7 @@ pub enum DataType {
     /// [clickhouse]: https://clickhouse.com/docs/en/sql-reference/data-types/nested-data-structures/nested
     Nested(Vec<ColumnDef>),
     /// Enums
-    Enum(Vec<EnumValue>, Option<i64>),
+    Enum(Vec<EnumMember>, Option<u32>),
     /// Set
     Set(Vec<String>),
     /// Struct
@@ -524,8 +524,8 @@ impl fmt::Display for DataType {
                         write!(f, ", ")?;
                     }
                     match v {
-                        EnumValue::String(v) => write!(f, "'{}'", escape_single_quote_string(v))?,
-                        EnumValue::Pair(v, i) => {
+                        EnumMember::Name(v) => write!(f, "'{}'", escape_single_quote_string(v))?,
+                        EnumMember::NameValue(v, i) => {
                             write!(f, "'{}' = {}", escape_single_quote_string(v), i)?
                         }
                     }

src/ast/mod.rs

@@ -40,7 +40,7 @@ use sqlparser_derive::{Visit, VisitMut};
 use crate::tokenizer::Span;
 
 pub use self::data_type::{
-    ArrayElemTypeDef, CharLengthUnits, CharacterLength, DataType, EnumValue, ExactNumberInfo,
+    ArrayElemTypeDef, CharLengthUnits, CharacterLength, DataType, EnumMember, ExactNumberInfo,
     StructBracketKind, TimezoneInfo,
 };
 pub use self::dcl::{AlterRoleOperation, ResetConfig, RoleOption, SetConfigValue, Use};

src/dialect/clickhouse.rs

@@ -50,10 +50,4 @@ impl Dialect for ClickHouseDialect {
     fn supports_limit_comma(&self) -> bool {
         true
     }
-
-    /// ClickHouse supports `Enum8` and `Enum16` types.
-    /// See [ClickHouse](https://clickhouse.com/docs/en/sql-reference/data-types/enum)
-    fn supports_enum_type_with_bits(&self) -> bool {
-        true
-    }
 }

src/dialect/mod.rs

@@ -687,11 +687,6 @@ pub trait Dialect: Debug + Any {
     fn is_reserved_for_identifier(&self, kw: Keyword) -> bool {
         keywords::RESERVED_FOR_IDENTIFIER.contains(&kw)
     }
-
-    /// Return true if the dialect supports the Enum type with bits like Enum8, Enum16
-    fn supports_enum_type_with_bits(&self) -> bool {
-        false
-    }
 }
 
 /// This represents the operators for which precedence must be defined