t/unit-tests: convert mem-pool to use clar test framework #1873
Conversation
t/unit-tests/generate-clar-decls.sh
Outdated
| @@ -14,6 +14,7 @@ do | |||
| suite_name=$(basename "$suite") | |||
| suite_name=${suite_name%.c} | |||
| suite_name=${suite_name#u-} | |||
| suite_name=$(echo "$suite_name" | sed 's/-/_/g') | |||
There was a problem hiding this comment.
This is fine as-is, but I think it's more customary in our codebase to use tr(1) instead. E.g. echo "$suite_name" | tr '-' '_').
| @@ -14,6 +14,7 @@ do | |||
| suite_name=$(basename "$suite") | |||
There was a problem hiding this comment.
This commit should be ordered before the first one as it is a mandatory prerequisite. The Git project aims for "bisectability", which means that every single commit in your patch series should always compile and test alright. With the current ordering that is not the case.
t/unit-tests/u-mem-pool.c
Outdated
| #include "unit-test.h" | ||
| #include "mem-pool.h" | ||
|
|
||
| static void t_calloc_100(struct mem_pool *pool) |
There was a problem hiding this comment.
None of the testcases do anything with their local pool. So how about we make this take as parameter the block_alloc size and have the function here handle the setup and teardown of the pool?
Adapt script to translate dashes (`-`) in test suite filenames to underscores (`_`) to ensure proper extraction of test function names. `generate-clar-decls.sh` does not pick up dashes in filenames such as `u-mem-pool.c`, which prevents the scripts from being run. This will be used by subsequent commits which follows the same construct. Mentored-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com>
Seyi007
force-pushed
the
convert-2-clar-phase2
branch
from
d31535b to
6cdf8a8
Compare
Adapt the mem-pool test script to use clar framework by using clar assertions where necessary. Following the consensus to convert the unit-tests scripts found in the t/unit-tests folder to clar driven by Patrick Steinhardt. Test functions are created as a standalone to test different test cases. Mentored-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com>
Seyi007
force-pushed
the
convert-2-clar-phase2
branch
2 times, most recently
from
ca6348f to
ae4d0f4
Compare
| while ((peek = prio_queue_peek(&pq))) { | ||
| get = prio_queue_get(&pq); | ||
| cl_assert(peek == get); | ||
| cl_assert((size_t)j < result_size); |
There was a problem hiding this comment.
Is this the cast you're talking about? If so, you can avoid the cast by converting the variable declaration of j to be a size_t directly. It's the right thing to do anyway, I'd say.
Convert the prio-queue test script to clar framework by using clar assertions where necessary. Following the consensus to convert the unit-tests scripts found in the t/unit-tests folder to clar driven by Patrick Steinhardt. Test functions are created as a standalone to test different cases. Mentored-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com>
Seyi007
force-pushed
the
convert-2-clar-phase2
branch
2 times, most recently
from
51274ad to
7f9a133
Compare
t/unit-tests/u-reftable-tree.c
Outdated
| { | ||
| TEST(t_tree_search(), "tree_search works"); | ||
| TEST(t_infix_walk(), "infix_walk works"); | ||
| t_tree_search(); |
There was a problem hiding this comment.
This is a bit curious. I would've expected you to inline t_tree_search() here.
t/unit-tests/u-reftable-tree.c
Outdated
| return test_done(); | ||
| void test_reftable_tree__infix_walk(void) | ||
| { | ||
| t_infix_walk(); |
There was a problem hiding this comment.
Same here, I think this should be inlined.
Adapts reftable tree test script to clar framework by using clar assertions where necessary. Following the consensus to convert the unit-tests scripts found in the t/unit-tests folder to clar driven by Patrick Steinhardt. Mentored-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com>
Seyi007
force-pushed
the
convert-2-clar-phase2
branch
from
7f9a133 to
905ab91
Compare
Adapt the mem-pool test functions to clar framework by using clar assertions where necessary. Following the consensus to convert the unit-tests scripts found in the t/unit-tests folder to clar driven by Patrick Steinhardt.
Mentored-by: Patrick Steinhardt ps@pks.im
Signed-off-by: Seyi Kuforiji kuforiji98@gmail.com