Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning for Brave users #5865

Closed
PaulRBerg opened this issue Jan 22, 2020 · 21 comments · Fixed by #5988
Closed

Add warning for Brave users #5865

PaulRBerg opened this issue Jan 22, 2020 · 21 comments · Fixed by #5988

Comments

@PaulRBerg
Copy link

PaulRBerg commented Jan 22, 2020 •
edited
Loading

In v1, Brave introduced their native crypto wallet, which is rather intrusive and overrides Metamask.

Some users told me they would've loved to contribute to our Sablier grant, but they couldn't because nothing happened after tapping the submit button. I jumped on TeamViewer to help them and it turned out that the issue was Brave - after disabling it, it went fine.

It'd be nice to display a warning for Brave users. Related: brave/brave-browser#6053
@LefterisJP
Copy link

Yeah I saw the same in the previous gitcoin round. That's why I disabled Brave's own crypto wallet.

@owocki
Copy link
Contributor

owocki commented Jan 22, 2020

adding a bounty for thsi. scope is to fix grant contributions (and cancellations) in brave's native wallet

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 0.5 ETH (83.55 USD @ $167.1/ETH) attached to it.

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Workers have applied to start work.

These users each claimed they can complete the work by 1 month from now.
Please review their action plans below:

1) iamonuwa has applied to start work (Funders only: approve worker | reject worker).

Check if browser is brave browser . Then show message

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link
Member

gitcoinbot commented Jan 22, 2020 •
edited
Loading

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 1 week, 2 days ago.
Please review their action plans below:

1) iamonuwa has applied to start work (Funders only: approve worker | reject worker).

Check if browser is brave browser . Then show message
2) iamonuwa has applied to start work (Funders only: approve worker | reject worker).

Check if browser is brave browser . Then show message
3) sebastiantf has been approved to start work.

Write code to detect what browser the user is using. Display a warning message to users if they're using Brave

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link
Member

@sebastiantf Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@sebastiantf
Copy link
Contributor

sebastiantf commented Jan 26, 2020 •
edited
Loading

Yes. I am working on this issue @gitcoinbot.

@sebastiantf
Copy link
Contributor

How would you like the warning to be displayed @PaulRBerg @owocki?

Should it look like an .alert like this:

gitcoin alert cropped

Or should it look like a .modal like this:

FireShot Capture 025 - Quests - Gitcoin - gitcoin co

@gitcoinbot
Copy link
Member

@sebastiantf Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@sebastiantf
Copy link
Contributor

@gitcoinbot I am working on this issue. I would like to receive a reply for the previous comment.

I shall move forward by trying to implement a .alert

@gitcoinbot
Copy link
Member

@sebastiantf Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@sebastiantf
Copy link
Contributor

Yes @gitcoinbot

@sebastiantf
Copy link
Contributor

@owocki @PaulRBerg Brave browser doesn't seem to provide a Brave-specific User Agent which makes detecting Brave browser difficult. See #1052

Since Brave Wallet is a fork of MetaMask, the web3.currentProvider.isMetamask returns true.

So it seems displaying the warning only for Brave users by detecting Brave Browser or Brave Wallet to be hard.

Is it okay to just display the following warning to all users visiting https://gitcoin.co/grants/?

Note: Brave users seem to have issues while contributing to Grants while using both Brave Wallet and MetaMask. We recommend disabling one. For more info, see this issue

grantswarning

@gitcoinbot
Copy link
Member

@sebastiantf Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@sebastiantf
Copy link
Contributor

sebastiantf commented Feb 13, 2020 •
edited
Loading

Yes @gitcoinbot

sebastiantf added a commit to sebastiantf/web that referenced this issue Feb 14, 2020
@sebastiantf
Fixes:gitcoinco#5865
72d3aa2
@sebastiantf sebastiantf mentioned this issue Feb 14, 2020
Merged
@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 0.5 ETH (134.64 USD @ $269.27/ETH) has been submitted by:

  1. @sebastiantf

@owocki please take a look at the submitted work:

sebastiantf added a commit to sebastiantf/web that referenced this issue Feb 16, 2020
@sebastiantf
Fixes:gitcoinco#5865
2617a23
thelostone-mc pushed a commit that referenced this issue Feb 17, 2020
@sebastiantf
Fixes:#5865 (#5988)
69cb771
@sebastiantf
Copy link
Contributor

@owocki My PR has been merged and this issue closed. I have submitted the work on Gitcoin. Please review my work as the bounty expires in 2 days.

@owocki
Copy link
Contributor

owocki commented Mar 3, 2020

just paid out

is there no way to detect the user is in brave and only display the message them? it seems really really clunky to get this warning on chrome

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 0.5 ETH (114.83 USD @ $229.66/ETH) attached to this issue has been approved & issued to @sebastiantf.

@sebastiantf
Copy link
Contributor

Thanks for the payment @owocki.

It seems it isn't possible to detect Brave users using the UA as they've removed Brave-specific strings from it to reduce fingerprinting as specified in this Changelog

Also see #1052

If any alternative method is found, we shall use that to detect Brave and show the warning specifically to Brave users.

@dlecan
Copy link

dlecan commented Jan 4, 2021

https://gist.github.com/drbh/250a77a438624bc2619f0518dd5b38fe + discussions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add warning for users visiting Grants page sebastiantf/web
6 participants
@owocki @dlecan @LefterisJP @PaulRBerg @gitcoinbot @sebastiantf