midx-write: fix leaking buffer

pks-t · gitster · commit 9d4855eef364 · 2024-09-30T11:23:07.000-07:00
The buffer used to compute the final MIDX name is never released. Plug
this memory leak.

Signed-off-by: Patrick Steinhardt &lt;ps@pks.im&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/midx-write.c b/midx-write.c
@@ -1445,6 +1445,8 @@ static int write_midx_internal(const char *object_dir,
 			return -1;
 		}
 
+		strbuf_release(&final_midx_name);
+
 		keep_hashes[ctx.num_multi_pack_indexes_before] =
 			xstrdup(hash_to_hex(midx_hash));
 
diff --git a/t/t5334-incremental-multi-pack-index.sh b/t/t5334-incremental-multi-pack-index.sh
@@ -1,6 +1,8 @@
 #!/bin/sh
 
 test_description='incremental multi-pack-index'
+
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 . "$TEST_DIRECTORY"/lib-midx.sh
 

Original file line number	Diff line number	Diff line change
`@@ -1445,6 +1445,8 @@ static int write_midx_internal(const char *object_dir,`
`1445`	`1445`	`return -1;`
`1446`	`1446`	`}`
`1447`	`1447`
	`1448`	`+ strbuf_release(&final_midx_name);`
	`1449`	`+`
`1448`	`1450`	`keep_hashes[ctx.num_multi_pack_indexes_before] =`
`1449`	`1451`	`xstrdup(hash_to_hex(midx_hash));`
`1450`	`1452`