Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .cake extension for C# #2707

Closed
wants to merge 2 commits into from
Closed

Conversation

Redth
Copy link
Contributor

@Redth Redth commented Oct 30, 2015

This adds the .cake file extension to the C# language.

Here is a search in the wild: https://github.com/search?q=extension%3Acake+NOT+coffee&type=Code

Cake (C# Make) is a cross platform build automation system with a C# DSL to do things like compiling code, copy files/folders, running unit tests, compress files and build NuGet packages.

You can find out out more about cake here: http://cakebuild.net/

This adds the .cake file extension to the C# language.

Here is a search in the wild: https://github.com/search?q=extension%3Acake+NOT+coffee&type=Code

Cake (C# Make) is a cross platform build automation system with a C# DSL to do things like compiling code, copy files/folders, running unit tests, compress files and build NuGet packages.

You can find out out more about cake here: http://cakebuild.net/
@@ -392,6 +392,7 @@ C#:
aliases:
- csharp
extensions:
- .cake
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first extension should be the primary one, .cs ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I had assumed entirely alphabetical, fixed now :)

@pchaigno
Copy link
Contributor

Using your search query, I found that there are 116 projects that use Cake files dispatched among 61 users. Not sure that it will be enough to make it a language in Linguist.

@Redth
Copy link
Contributor Author

Redth commented Oct 31, 2015

@pchaigno if it's any help, support for cake was merged into Atom already atom/language-csharp#30

@pchaigno
Copy link
Contributor

pchaigno commented Nov 1, 2015

support for cake was merged into Atom already

Does that mean that Cake doesn't have the same syntax as C#?

@Redth
Copy link
Contributor Author

Redth commented Nov 1, 2015

It was added with the same syntax as C#. Cake is in fact C# (cake scripts are run under the roslyn script host engine - mono script host on mac/unix). Cake does contain a few more possible preprocessor directives but the syntax highlighting is the same as normal C#.

@pchaigno
Copy link
Contributor

pchaigno commented Nov 1, 2015

I see, it's a second grammar file referring the C# one. We'll have to declare Cake as a second file with C# as the parent language (meaning Cake will be displayed as C# but we'll be able to use a different grammar file for it).

First we should make sure that 116 projects with Cake files is enough... @arfon?

@Redth
Copy link
Contributor Author

Redth commented Nov 2, 2015

Hmm, I didn't realize that this already exists: /vendor/grammars/language-csharp/source.cake

Does that make things easier?

EDIT: Looks like @arfon already added this? 0a6165c

@pchaigno
Copy link
Contributor

pchaigno commented Nov 2, 2015

Does that make things easier?

Yes, we won't have to add the grammar but we'll still have to declare a separate language.

EDIT: Looks like @arfon already added this? 0a6165c

That's just because he updated the grammar submodule ;)

@gep13
Copy link

gep13 commented Nov 19, 2015

@pchaigno @arfon I was just wondering what the status of this is? After yesterday's announcements, Cake is now a first class citizen in both the VS Code and Visual Studio Team Services (formerly VSO) extension galleries:

https://marketplace.visualstudio.com/items/cake-build.cake-vscode
https://marketplace.visualstudio.com/items/cake-build.cake

Just wondering if this helps the case for getting this support included.

@arfon arfon mentioned this pull request Nov 20, 2015
@arfon
Copy link
Contributor

arfon commented Nov 20, 2015

Thanks @Redth - I've got an updated version of this Pull Request going in #2733

@arfon arfon closed this Nov 20, 2015
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants