Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events #63

Merged
merged 5 commits into from
Apr 20, 2023
Merged

Events #63

merged 5 commits into from
Apr 20, 2023

Conversation

keithamus
Copy link
Member

@keithamus keithamus commented Apr 20, 2023

This rewrites the events to be a little more type safe, by using custom classes for each event type. This also adds get/set properties which can make it possible to bind these events when used in React.

Refs https://github.com/github/primer/issues/2138

@keithamus keithamus requested a review from a team as a code owner April 20, 2023 11:14
@primer-css
Copy link

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

  • 🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
  • If this is a PR that includes changes to an interaction, please include a video recording in the description.
  • ⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

src/auto-check-element.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@rezrah rezrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.. though i'm not super familiar with the source. Seems to do what it says on the tin though, so 👍.

Co-authored-by: Rez <rezrah@github.com>
@keithamus keithamus merged commit a859ad7 into main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants