From 232500c05c3837a51a5a37eab55da004094b77f4 Mon Sep 17 00:00:00 2001 From: "Michael B. Gale" Date: Wed, 17 Sep 2025 16:54:20 +0100 Subject: [PATCH] Use `browser_download_url` instead of `url` --- lib/start-proxy-action.js | 4 ++-- src/start-proxy.test.ts | 7 +++++-- src/start-proxy.ts | 4 ++-- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/lib/start-proxy-action.js b/lib/start-proxy-action.js index ac2e1c5af1..10124aafcc 100644 --- a/lib/start-proxy-action.js +++ b/lib/start-proxy-action.js @@ -49528,10 +49528,10 @@ async function getDownloadUrl(logger) { for (const asset of cliRelease.data.assets) { if (asset.name === proxyPackage) { logger.info( - `Found '${proxyPackage}' in release '${bundleVersion}' at '${asset.url}'` + `Found '${proxyPackage}' in release '${bundleVersion}' at '${asset.browser_download_url}'` ); return { - url: asset.url, + url: asset.browser_download_url, // The `update-job-proxy` doesn't have a version as such. Since we now bundle it // with CodeQL CLI bundle releases, we use the corresponding CLI version to // differentiate between (potentially) different versions of `update-job-proxy`. diff --git a/src/start-proxy.test.ts b/src/start-proxy.test.ts index dfd55d72fc..f3ef5e24a5 100644 --- a/src/start-proxy.test.ts +++ b/src/start-proxy.test.ts @@ -255,8 +255,11 @@ test("getDownloadUrl returns fallback when there's no matching release asset", a test("getDownloadUrl returns matching release asset", async (t) => { const assets = [ - { name: "foo", url: "other-url" }, - { name: startProxyExports.getProxyPackage(), url: "url-we-want" }, + { name: "foo", browser_download_url: "other-url" }, + { + name: startProxyExports.getProxyPackage(), + browser_download_url: "url-we-want", + }, ]; mockGetReleaseByTag(assets); diff --git a/src/start-proxy.ts b/src/start-proxy.ts index dd1e443b76..2965826b2f 100644 --- a/src/start-proxy.ts +++ b/src/start-proxy.ts @@ -231,10 +231,10 @@ export async function getDownloadUrl( for (const asset of cliRelease.data.assets) { if (asset.name === proxyPackage) { logger.info( - `Found '${proxyPackage}' in release '${defaults.bundleVersion}' at '${asset.url}'`, + `Found '${proxyPackage}' in release '${defaults.bundleVersion}' at '${asset.browser_download_url}'`, ); return { - url: asset.url, + url: asset.browser_download_url, // The `update-job-proxy` doesn't have a version as such. Since we now bundle it // with CodeQL CLI bundle releases, we use the corresponding CLI version to // differentiate between (potentially) different versions of `update-job-proxy`.