diff --git a/.github/workflows/browser-test.yml b/.github/workflows/browser-test.yml index 18e0166879ab..aaf41978b3b0 100644 --- a/.github/workflows/browser-test.yml +++ b/.github/workflows/browser-test.yml @@ -20,22 +20,18 @@ jobs: paths: '[".github/workflows/browser-test.yml","assets/**", "content/**", "data/**", "includes/**", "javascripts/**", "jest-puppeteer.config.js", "jest.config.js", "layouts/**", "lib/**", "middleware/**", "package-lock.json", "package.json", "server.js", "translations/**", "webpack.config.js"]' build: needs: see_if_should_skip + if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }} runs-on: ubuntu-latest steps: - # Each of these ifs needs to be repeated at each step to make sure the required check still runs - # Even if if doesn't do anything - - if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }} - name: Checkout + - name: Checkout uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f - - if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }} - name: Install + - name: Install uses: ianwalter/puppeteer@12728ddef82390d1ecd4732fb543f62177392fbb with: args: npm ci - - if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }} - name: Test + - name: Test uses: ianwalter/puppeteer@12728ddef82390d1ecd4732fb543f62177392fbb with: args: npm run browser-test diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 89c78378b802..81fc1f47c97b 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -31,6 +31,7 @@ jobs: test: needs: see_if_should_skip + if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }} runs-on: ubuntu-latest timeout-minutes: 60 strategy: @@ -38,26 +39,20 @@ jobs: matrix: test-group: [content, meta, rendering, routing, unit, links-and-images] steps: - # Each of these ifs needs to be repeated at each step to make sure the required check still runs - # Even if if doesn't do anything - - if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }} - name: Check out repo + - name: Check out repo uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f - - if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }} - name: Setup node + - name: Setup node uses: actions/setup-node@56899e050abffc08c2b3b61f3ec6a79a9dc3223d with: node-version: 14.x - - if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }} - name: Get npm cache directory + - name: Get npm cache directory id: npm-cache run: | echo "::set-output name=dir::$(npm config get cache)" - - if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }} - name: Cache node modules + - name: Cache node modules uses: actions/cache@d1255ad9362389eac595a9ae406b8e8cb3331f16 with: path: ${{ steps.npm-cache.outputs.dir }} @@ -65,16 +60,13 @@ jobs: restore-keys: | ${{ runner.os }}-node- - - if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }} - name: Install dependencies + - name: Install dependencies run: npm ci - - if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }} - name: Run build script + - name: Run build script run: npm run build - - if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }} - name: Run tests + - name: Run tests run: npx jest tests/${{ matrix.test-group }}/ env: NODE_OPTIONS: "--max_old_space_size=4096"