Skip to content

Conversation

@joshjohanning
Copy link
Contributor

@joshjohanning joshjohanning commented Feb 23, 2021

Why:

The article doesn't otherwise mention how to authenticate to GitHub Packages in a GitHub Actions workflow - it just links to a generic GITHUB_TOKEN page. The dotnet nuget add source command allows for authenticating to GitHub packages without having to source control a GitHub token.

I thought this simple one-liner would be very helpful in consuming GitHub Packages in a an effecient manner instead of having to sift through Stack Overflow posts on how to do this.

What's being changed:

Adding an example command that can be used to authenticate to GitHub Packages in a GitHub Action without committing a secret to source control:

dotnet nuget add source --username USERNAME --password ${{ secrets.GITHUB_TOKEN }} --store-password-in-clear-text --name github "https://nuget.pkg.github.com/OWNER/index.json"

(If this link still works) The change can be found on the Heroku page here:
image

Check off the following:

The article doesn't otherwise mention how to authenticate to GitHub Packages in an Action - it just links to a non-helpful GITHUB_TOKEN page. The dotnet nuget add source allows for authenticating to GitHub packages without having to source control a GitHub token.
@welcome
Copy link

welcome bot commented Feb 23, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@joshjohanning joshjohanning marked this pull request as ready for review February 23, 2021 20:22
@janiceilene
Copy link
Contributor

Thanks so much for opening a PR and explaining your changes so thoroughly @soccerjoshj07! I'll get this triaged for review ✨

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team packages This issue or pull request should be reviewed by the docs packages team waiting for review Issue/PR is waiting for a writer's review labels Feb 23, 2021
@megbird megbird self-assigned this Mar 3, 2021
@lecoursen lecoursen assigned lecoursen and unassigned lecoursen May 4, 2021
@lee-dohm
Copy link
Contributor

lee-dohm commented May 6, 2021

Hey @soccerjoshj07, our sincere apologies for not getting back to you on this PR.

It's my understanding that the page you're changing in this PR no longer exists and the information has been moved. We believe that the change you're proposing would still be useful but it would probably best be added to this page: https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-nuget-registry#authenticating-to-github-packages. Would you mind updating the PR or creating a new one with the change in the new location?

Let us know! And again, I apologize for it taking so long to get back to you. We're still working out the bugs in our process here, please bear with us!

@joshjohanning
Copy link
Contributor Author

@lee-dohm

No worries. Creating new PR #6140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team packages This issue or pull request should be reviewed by the docs packages team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants