From 26d40e3b6f3650ce124046ceab896a6780ae32e9 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 25 Jan 2026 03:32:46 +0000 Subject: [PATCH 1/2] Initial plan From 1641d9d6ef92520be59fd2e081631cdd2444395c Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 25 Jan 2026 03:46:00 +0000 Subject: [PATCH 2/2] Align additionalProperties and enum values between schemas - Remove "remote" from generic MCP tool type/mode enums (only valid for GitHub tool) - Change additionalProperties from true to false for strict validation - Add schema comments documenting the decisions - Schemas now consistently validate MCP configurations Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --- pkg/parser/schemas/main_workflow_schema.json | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/pkg/parser/schemas/main_workflow_schema.json b/pkg/parser/schemas/main_workflow_schema.json index 9aafd0d3ea..051569aaac 100644 --- a/pkg/parser/schemas/main_workflow_schema.json +++ b/pkg/parser/schemas/main_workflow_schema.json @@ -3427,12 +3427,14 @@ }, "mode": { "type": "string", - "enum": ["stdio", "http", "remote", "local"], + "enum": ["stdio", "http", "local"], + "$comment": "Note: 'remote' is only valid for the GitHub tool's mode field, not for generic MCP server configurations. Valid types: stdio (command/container), http (URL-based), local (alias for stdio).", "description": "MCP server mode" }, "type": { "type": "string", - "enum": ["stdio", "http", "remote", "local"], + "enum": ["stdio", "http", "local"], + "$comment": "Note: 'remote' is only valid for the GitHub tool's mode field, not for generic MCP server configurations. Valid types: stdio (command/container), http (URL-based), local (alias for stdio).", "description": "MCP server type" }, "version": { @@ -3471,7 +3473,8 @@ "description": "Arguments passed to container entrypoint" } }, - "additionalProperties": true + "$comment": "Strict validation: additionalProperties set to false to match mcp_config_schema.json and ensure consistent validation of custom MCP tools. Only explicitly defined properties are allowed.", + "additionalProperties": false } ] }