From d472f5402165ce95c1f29db04412e28be5315116 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 25 Jan 2026 22:52:40 +0000 Subject: [PATCH 1/4] Initial plan From 96dfc475dda4502942ef0e42b954d5917a69346b Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 25 Jan 2026 23:02:16 +0000 Subject: [PATCH 2/4] Fix: Remove redundant Phase 6 manual discussion closure in daily-observability-report Phase 6 instructed the agent to manually search for and close previous observability discussions. However, this is already handled automatically by the `close-older-discussions: true` setting in the safe-outputs configuration. This redundancy could cause: - Unnecessary tool calls and processing time - Potential conflicts if the agent tries to close already-closed discussions - Confusion for the agent about which method to use Fixed by: - Removing the redundant Phase 6 instructions - Renumbering Phase 7 to Phase 6 - Adding a note explaining the automatic closure behavior - Recompiled workflow to generate updated .lock.yml file The `close-older-discussions: true` setting automatically closes up to 10 older discussions matching the same title prefix ("[observability]") with "OUTDATED" reason and a comment linking to the new discussion. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --- .../workflows/daily-observability-report.lock.yml | 14 +++----------- .github/workflows/daily-observability-report.md | 12 +++--------- 2 files changed, 6 insertions(+), 20 deletions(-) diff --git a/.github/workflows/daily-observability-report.lock.yml b/.github/workflows/daily-observability-report.lock.yml index 184909a36a..ef3416bc6d 100644 --- a/.github/workflows/daily-observability-report.lock.yml +++ b/.github/workflows/daily-observability-report.lock.yml @@ -975,18 +975,12 @@ jobs: Create a summary table of all runs analyzed with their observability status. - ## Phase 6: Close Previous Reports - - Before creating the new discussion, find and close previous observability reports: - - 1. Search for discussions with title prefix "[observability]" - 2. Close each found discussion with reason "OUTDATED" - 3. Add a closing comment: "This report has been superseded by a newer observability report." - - ## Phase 7: Create Discussion Report + ## Phase 6: Create Discussion Report Create a new discussion with the comprehensive observability report. + **Note**: Previous observability reports with the same `[observability]` prefix will be automatically closed when the new discussion is created. This is handled by the `close-older-discussions: true` setting in the safe-outputs configuration - you don't need to manually close them. + ### Discussion Format **Title**: `[observability] Observability Coverage Report - YYYY-MM-DD` @@ -1127,8 +1121,6 @@ jobs: - ✅ Create a new discussion with comprehensive report - ✅ Include actionable recommendations - PROMPT_EOF - cat << 'PROMPT_EOF' >> "$GH_AW_PROMPT" Begin your analysis now. Download the logs, analyze observability coverage, and create the discussion report. PROMPT_EOF diff --git a/.github/workflows/daily-observability-report.md b/.github/workflows/daily-observability-report.md index 01a29f4739..6cbaea5de6 100644 --- a/.github/workflows/daily-observability-report.md +++ b/.github/workflows/daily-observability-report.md @@ -273,18 +273,12 @@ runs_with_missing_logs = (firewall_enabled_workflows - firewall_logs_present) + Create a summary table of all runs analyzed with their observability status. -## Phase 6: Close Previous Reports - -Before creating the new discussion, find and close previous observability reports: - -1. Search for discussions with title prefix "[observability]" -2. Close each found discussion with reason "OUTDATED" -3. Add a closing comment: "This report has been superseded by a newer observability report." - -## Phase 7: Create Discussion Report +## Phase 6: Create Discussion Report Create a new discussion with the comprehensive observability report. +**Note**: Previous observability reports with the same `[observability]` prefix will be automatically closed when the new discussion is created. This is handled by the `close-older-discussions: true` setting in the safe-outputs configuration - you don't need to manually close them. + ### Discussion Format **Title**: `[observability] Observability Coverage Report - YYYY-MM-DD` From aed374cdd5216599d449e8a2193d554977019062 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 25 Jan 2026 23:03:09 +0000 Subject: [PATCH 3/4] Debug complete: Fixed redundant discussion closure in daily-observability-report Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --- .github/workflows/daily-observability-report.lock.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/daily-observability-report.lock.yml b/.github/workflows/daily-observability-report.lock.yml index ef3416bc6d..0a8bdd2423 100644 --- a/.github/workflows/daily-observability-report.lock.yml +++ b/.github/workflows/daily-observability-report.lock.yml @@ -158,7 +158,7 @@ jobs: env: TOKEN_CHECK: ${{ secrets.GH_AW_GITHUB_MCP_SERVER_TOKEN }} if: env.TOKEN_CHECK != '' - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + uses: actions/github-script@v8 with: script: | const determineAutomaticLockdown = require('/opt/gh-aw/actions/determine_automatic_lockdown.cjs'); From 023770bb494f398074d7b476acfe15305b168bca Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 25 Jan 2026 23:03:58 +0000 Subject: [PATCH 4/4] Update success criteria to reflect automatic discussion closure Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --- .github/workflows/daily-observability-report.lock.yml | 5 ++--- .github/workflows/daily-observability-report.md | 3 +-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/workflows/daily-observability-report.lock.yml b/.github/workflows/daily-observability-report.lock.yml index 0a8bdd2423..85402f86d9 100644 --- a/.github/workflows/daily-observability-report.lock.yml +++ b/.github/workflows/daily-observability-report.lock.yml @@ -158,7 +158,7 @@ jobs: env: TOKEN_CHECK: ${{ secrets.GH_AW_GITHUB_MCP_SERVER_TOKEN }} if: env.TOKEN_CHECK != '' - uses: actions/github-script@v8 + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 with: script: | const determineAutomaticLockdown = require('/opt/gh-aw/actions/determine_automatic_lockdown.cjs'); @@ -1117,8 +1117,7 @@ jobs: - ✅ Check all MCP-enabled runs for gateway.jsonl presence - ✅ Calculate coverage percentages and identify gaps - ✅ Flag any runs missing critical logs as CRITICAL - - ✅ Close previous observability discussions - - ✅ Create a new discussion with comprehensive report + - ✅ Create a new discussion with comprehensive report (previous discussions automatically closed) - ✅ Include actionable recommendations Begin your analysis now. Download the logs, analyze observability coverage, and create the discussion report. diff --git a/.github/workflows/daily-observability-report.md b/.github/workflows/daily-observability-report.md index 6cbaea5de6..34ca3faa95 100644 --- a/.github/workflows/daily-observability-report.md +++ b/.github/workflows/daily-observability-report.md @@ -415,8 +415,7 @@ A successful run will: - ✅ Check all MCP-enabled runs for gateway.jsonl presence - ✅ Calculate coverage percentages and identify gaps - ✅ Flag any runs missing critical logs as CRITICAL -- ✅ Close previous observability discussions -- ✅ Create a new discussion with comprehensive report +- ✅ Create a new discussion with comprehensive report (previous discussions automatically closed) - ✅ Include actionable recommendations Begin your analysis now. Download the logs, analyze observability coverage, and create the discussion report.