diff --git a/pkg/workflow/action_cache.go b/pkg/workflow/action_cache.go index 8cc48beaa8..435c608575 100644 --- a/pkg/workflow/action_cache.go +++ b/pkg/workflow/action_cache.go @@ -238,8 +238,8 @@ func (c *ActionCache) deduplicateEntries() { } // For each group with multiple entries, keep only the most precise one - toDelete := make([]string, 0) - deduplicationDetails := make([]string, 0) // Track details for user-friendly message + var toDelete []string + var deduplicationDetails []string // Track details for user-friendly message for ek, keys := range groups { if len(keys) <= 1 { @@ -276,7 +276,7 @@ func (c *ActionCache) deduplicateEntries() { // Keep the most precise version, mark others for deletion keepVersion := keyInfos[0].versionRef - removedVersions := make([]string, 0) + var removedVersions []string for i := 1; i < len(keyInfos); i++ { toDelete = append(toDelete, keyInfos[i].key) removedVersions = append(removedVersions, keyInfos[i].versionRef) diff --git a/pkg/workflow/compiler_safe_outputs_job.go b/pkg/workflow/compiler_safe_outputs_job.go index b95cd9c7ec..07a48f2ab9 100644 --- a/pkg/workflow/compiler_safe_outputs_job.go +++ b/pkg/workflow/compiler_safe_outputs_job.go @@ -369,7 +369,7 @@ func (c *Compiler) buildConsolidatedSafeOutputsJob(data *WorkflowData, mainJobNa } // Insert app token steps - newSteps := make([]string, 0) + var newSteps []string newSteps = append(newSteps, steps[:insertIndex]...) newSteps = append(newSteps, appTokenSteps...) newSteps = append(newSteps, steps[insertIndex:]...) diff --git a/pkg/workflow/jobs.go b/pkg/workflow/jobs.go index 77e9e708f3..e6d82ed541 100644 --- a/pkg/workflow/jobs.go +++ b/pkg/workflow/jobs.go @@ -44,8 +44,7 @@ type JobManager struct { // NewJobManager creates a new JobManager instance func NewJobManager() *JobManager { return &JobManager{ - jobs: make(map[string]*Job), - jobOrder: make([]string, 0), + jobs: make(map[string]*Job), } } @@ -429,7 +428,7 @@ func (jm *JobManager) GetTopologicalOrder() ([]string, error) { } // Start with jobs that have no dependencies (in-degree = 0) - queue := make([]string, 0) + var queue []string for jobName, degree := range inDegree { if degree == 0 { queue = append(queue, jobName) diff --git a/pkg/workflow/mcp_setup_generator.go b/pkg/workflow/mcp_setup_generator.go index 180e17cf0e..9371e06c8e 100644 --- a/pkg/workflow/mcp_setup_generator.go +++ b/pkg/workflow/mcp_setup_generator.go @@ -604,7 +604,7 @@ func (c *Compiler) generateMCPSetup(yaml *strings.Builder, tools map[string]any, } // Add remaining environment variables from mcpEnvVars - envVarNames := make([]string, 0) + var envVarNames []string for envVarName := range mcpEnvVars { if !addedEnvVars[envVarName] { envVarNames = append(envVarNames, envVarName) diff --git a/pkg/workflow/step_order_validation.go b/pkg/workflow/step_order_validation.go index 3093ad9c8b..9a3b955cd2 100644 --- a/pkg/workflow/step_order_validation.go +++ b/pkg/workflow/step_order_validation.go @@ -39,7 +39,6 @@ type StepOrderTracker struct { // NewStepOrderTracker creates a new step order tracker func NewStepOrderTracker() *StepOrderTracker { return &StepOrderTracker{ - steps: make([]StepRecord, 0), nextOrder: 0, } }