From 56ae282180ba1093ed3d5a071c0f5da7d6b0ab7f Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 1 Jan 2026 21:05:09 +0000 Subject: [PATCH 1/3] Initial plan From fa256384f49377b1299017f5df69ec8066db2515 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 1 Jan 2026 21:11:58 +0000 Subject: [PATCH 2/3] Initial plan for CI cleanup - fix linting issues Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --- pkg/workflow/schemas/github-workflow.json | 60 ++++++++++++----------- 1 file changed, 31 insertions(+), 29 deletions(-) diff --git a/pkg/workflow/schemas/github-workflow.json b/pkg/workflow/schemas/github-workflow.json index 7f311b4093..7a3b674740 100644 --- a/pkg/workflow/schemas/github-workflow.json +++ b/pkg/workflow/schemas/github-workflow.json @@ -122,32 +122,6 @@ "required": ["image"], "additionalProperties": false }, - "snapshot": { - "$comment": "https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idsnapshot", - "description": "Specifies a custom image to generate for GitHub Actions workflows. This can be a simple image name string or a detailed mapping with version information.", - "oneOf": [ - { - "type": "string", - "description": "A simple image name string for the snapshot" - }, - { - "type": "object", - "properties": { - "image-name": { - "type": "string", - "description": "The name of the image to generate" - }, - "version": { - "type": "string", - "description": "The version of the image", - "pattern": "^[a-zA-Z0-9._-]+$" - } - }, - "required": ["image-name"], - "additionalProperties": false - } - ] - }, "defaults": { "type": "object", "properties": { @@ -377,6 +351,34 @@ } ] }, + "snapshot": { + "$comment": "https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#jobsjob_idsnapshot", + "description": "You can use `jobs..snapshot` to generate a custom image.\nAdd the snapshot keyword to the job, using either the string syntax or mapping syntax as shown in https://docs.github.com/en/actions/how-tos/manage-runners/larger-runners/use-custom-images#generating-a-custom-image.\nEach job that includes the snapshot keyword creates a separate image. To generate only one image or image version, include all workflow steps in a single job. Each successful run of a job that includes the snapshot keyword creates a new version of that image.\nFor more information, see https://docs.github.com/en/actions/how-tos/manage-runners/larger-runners/use-custom-images.", + "oneOf": [ + { + "$comment": "https://docs.github.com/en/actions/how-tos/manage-runners/larger-runners/use-custom-images#string-syntax", + "type": "string", + "description": "You can use the string syntax with `snapshot` to define the image name. This method creates a new image or adds a new version to an existing image with the same name. You cannot specify a version number using this syntax." + }, + { + "$comment": "https://docs.github.com/en/actions/how-tos/manage-runners/larger-runners/use-custom-images#mapping-syntax", + "type": "object", + "additionalProperties": false, + "description": "You can use the mapping syntax with `snapshot` to define both the `image-name` and the optional `version`. When you specify a major version, the minor versioning automatically increments if that major version already exists. Patch versions are not supported.", + "properties": { + "image-name": { + "type": "string" + }, + "version": { + "$comment": "https://docs.github.com/en/actions/how-tos/manage-runners/larger-runners/use-custom-images#specifying-a-version-in-your-workflow", + "type": "string", + "pattern": "^\\d+(\\.\\d+|\\*)?$" + } + }, + "required": ["image-name"] + } + ] + }, "step": { "type": "object", "additionalProperties": false, @@ -649,6 +651,9 @@ "needs": { "$ref": "#/definitions/jobNeeds" }, + "snapshot": { + "$ref": "#/definitions/snapshot" + }, "permissions": { "$ref": "#/definitions/permissions" }, @@ -831,9 +836,6 @@ "$ref": "#/definitions/concurrency" } ] - }, - "snapshot": { - "$ref": "#/definitions/snapshot" } }, "required": ["runs-on"], From e0833d055db96ef22dbc440083ab5d7b1c8fbcf1 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 1 Jan 2026 21:19:01 +0000 Subject: [PATCH 3/3] Remove unused logger variables to fix linting issues Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --- pkg/workflow/copilot_engine.go | 3 --- pkg/workflow/copilot_engine_tools.go | 3 --- 2 files changed, 6 deletions(-) diff --git a/pkg/workflow/copilot_engine.go b/pkg/workflow/copilot_engine.go index 4340e2c40d..4a0ed9f903 100644 --- a/pkg/workflow/copilot_engine.go +++ b/pkg/workflow/copilot_engine.go @@ -16,11 +16,8 @@ package workflow import ( "github.com/githubnext/gh-aw/pkg/constants" - "github.com/githubnext/gh-aw/pkg/logger" ) -var copilotLog = logger.New("workflow:copilot_engine") - const logsFolder = "/tmp/gh-aw/sandbox/agent/logs/" // CopilotEngine represents the GitHub Copilot CLI agentic engine. diff --git a/pkg/workflow/copilot_engine_tools.go b/pkg/workflow/copilot_engine_tools.go index 311604f8cb..3300075dc8 100644 --- a/pkg/workflow/copilot_engine_tools.go +++ b/pkg/workflow/copilot_engine_tools.go @@ -26,11 +26,8 @@ import ( "strings" "github.com/githubnext/gh-aw/pkg/constants" - "github.com/githubnext/gh-aw/pkg/logger" ) -var copilotToolsLog = logger.New("workflow:copilot_engine_tools") - // computeCopilotToolArguments computes the --allow-tool arguments for Copilot CLI based on tool configurations. // It handles bash/shell tools, edit tools, safe outputs, safe inputs, and MCP server tools. // Returns a sorted list of arguments ready to be passed to the Copilot CLI.