Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped Redcarpet to 3.3.2 #149

Merged
merged 1 commit into from
Jul 10, 2015
Merged

Conversation

Stargator
Copy link
Contributor

Versions 3.3.2 has a fix for a potential security issue in the HTML renderer

@envygeeks
Copy link

/cc @benbalter

@gjtorikian
Copy link
Contributor

We actually deployed this internally to our Pages servers a week or so ago, as the security issue was disclosed to us by @vmg. Apologies that it's not in the public gem yet.

Right now we are sussing out another potential issue, but we will merge and release this soon.

@nerab
Copy link

nerab commented Jul 10, 2015

Would be great to see this merged for the security fixes in redcarpet

@Starefossen
Copy link

+1

@gjtorikian
Copy link
Contributor

As I said above:

We actually deployed this internally to our Pages servers a week or so ago, as the security issue was disclosed to us by @vmg.

If you head to https://pages.github.com/versions/, you'll see the dynamically generated versions of all the gems we run in production. The entire company is heading out to our annual Summit next week, so we'll try to take care of this in the public release of the gem 🔜.

@nerab
Copy link

nerab commented Jul 10, 2015

github's pages are one thing, but dropcaster depends on the gh_pages, which still points to 3.3.1. So I cannot fix dropcaster until this PR was merged. Or is there a better way?

@envygeeks
Copy link

@nerab Switch to the Github pages "like" Docker image that we provide on Jekyll then, we use almost the same dependency chain but like Github we diverge if we want to force a specific version for specific reasons.

gjtorikian added a commit that referenced this pull request Jul 10, 2015
@gjtorikian gjtorikian merged commit f086f64 into github:master Jul 10, 2015
@gjtorikian
Copy link
Contributor

Or is there a better way?

I've just merged the PR in but am not doing a release just yet. Assuming you're using Bundler, you can refer directly to the gem with :git => 'https://github.com/github/pages-gem.git', :branch => 'master' until we can get a proper release out. Sorry for the trouble. Part of the complication here is that we were also sussing out a segfault around the same time as the Redcarpet bump.

@nerab
Copy link

nerab commented Jul 10, 2015

OK, will try that. Thanks!

@Stargator Stargator deleted the bump-redcarpet branch July 11, 2015 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants