Add arm64 builds for macOS, and build them from GH Actions #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiou87
force-pushed
the
darwin-arm64-support
branch
from
de93522
to
ba50390
Compare
sergiou87
changed the title
sergiou87
force-pushed
the
darwin-arm64-support
branch
2 times, most recently
from
e1b0b33
to
0574313
Compare
sergiou87
force-pushed
the
darwin-arm64-support
branch
from
3dc813e
to
b0bebd9
Compare
sergiou87
changed the title
sergiou87
commented
Apr 27, 2021
|
|
||
| - name: Build | ||
| run: | | ||
| CGO_ENABLED=1 GOARCH=${{ matrix.arch }} GO111MODULE=on go build \ |
There was a problem hiding this comment.
Adding these two (CGO_ENABLED=1 GOARCH=${{ matrix.arch }}) is basically all I needed to get it building for arm64:
GOARCHenables cross-compiling.CGO_ENABLED=1is required to build some of the C modules, because CGO gets disabled on cross-compiling.
|
Thanks for this PR! FYI, we've had to overhaul our build process for Actions. See #82 We don't currently have a permanent maintainer for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to get https://github.com/desktop/desktop builds for macOS arm64, we need to build git in https://github.com/desktop/dugite-native for arm64, and in order to do that we need smimesign built for arm64 😄
I hope this is enough to make it happen 🤞
Spoiler: it doesn't yet, I'll work on this 😂After some work it seems Travis doesn't want to help me get those builds, so I directly migrated the macOS CI script to GitHub Actions.
I will probably do the same for Windows in a different PR, Soon™…