Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tsx erros in LabelContainer #133

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Marvedog
Copy link

@Marvedog Marvedog commented Sep 19, 2022

Give me a heads up if you want me to update the formatting.

I have verified this by running the following locally

  1. yarn add --peer react-native react
  2. yarn add --dev typescript
  3. Run tsc ./*.tsx ./*.ts --noImplicitReturns --noImplicitThis --noImplicitAny --jsx react-native

renderContent,
...restProps
}: Props<T> & StyleProp<ViewProps>) => {
const [value, setValue] = useState<T | typeof Number.NaN>(Number.NaN);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setValue is a method which is called on this component's ref here.
It can't be a state variable.
The reason is described here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants