Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLens Inspect: "Files Changed" not following when switching between commits in File History #2814

Closed
GrimmiMeloni opened this issue Jul 16, 2023 · 4 comments
Assignees
Labels
bug Something isn't working support-triaged Support has reviewed, verified, or reproduced this verified ✔ Verified
Milestone

Comments

@GrimmiMeloni
Copy link

Description

  1. File A has several commits in its history.
  2. Open the file
  3. Open GitLens Inpsect sidebar
  4. In File History, click on a commit which not only changed File A, but also has changed File B
  5. On the files changed tab, click File B
  6. On the files changed tab, again click File A
  7. In the File History, click any other commit
  8. Files Changed, Commit Details, etc... everything is "stuck" on the previously selected commit

GitLens Version

14.1.0

VS Code Version

Version: 1.80.1
Commit: 74f6148eb9ea00507ec113ec51c489d6ffb4b771
Date: 2023-07-12T17:20:58.115Z
Electron: 22.3.14
ElectronBuildId: 21893604
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0

OS: Darwin arm64 22.5.0

Git Version

git version 2.39.2 (Apple Git-143)

Logs, Screenshots, Screen Captures, etc

Bildschirmaufnahme.2023-07-16.um.08.56.07.mov
@GrimmiMeloni GrimmiMeloni added bug Something isn't working triage Needs to be looked at labels Jul 16, 2023
@jkelroy jkelroy added support-triaged Support has reviewed, verified, or reproduced this and removed triage Needs to be looked at labels Jul 18, 2023
@eamodio eamodio assigned eamodio and d13 and unassigned eamodio Jul 18, 2023
@eamodio eamodio added this to the 14.2 milestone Jul 18, 2023
@eamodio
Copy link
Member

eamodio commented Jul 18, 2023

@d13 Can you take a look at this -- my guess is it has to do with the "soft" pinning we do when you click on a file in the commit details view.

@eamodio eamodio modified the milestones: 14.2, 14.3 Aug 8, 2023
@eamodio eamodio modified the milestones: 14.3, 14.4 Sep 8, 2023
@eamodio eamodio modified the milestones: 14.4, 14.5 Oct 18, 2023
@eamodio eamodio assigned eamodio and unassigned d13 Oct 18, 2023
@eamodio eamodio added pending-release Resolved but not yet released to the stable edition needs-verification Request for verification labels Oct 18, 2023
@eamodio
Copy link
Member

eamodio commented Oct 18, 2023

Can you please verify this fix in tomorrow's (v2023.10.18xx) pre-release edition of GitLens? Thank you so much!

You can switch to the pre-release edition of GitLens, by clicking on the "Switch to Pre-Release version of this extension" from the Extensions view.

image

@GrimmiMeloni
Copy link
Author

GrimmiMeloni commented Oct 18, 2023

@eamodio lgtm in pre-release. Thanks for fixing this! 👍🏻

@eamodio eamodio added verified ✔ Verified and removed needs-verification Request for verification labels Oct 18, 2023
@axosoft-ramint axosoft-ramint removed the pending-release Resolved but not yet released to the stable edition label Nov 14, 2023
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working support-triaged Support has reviewed, verified, or reproduced this verified ✔ Verified
Projects
None yet
Development

No branches or pull requests

5 participants