Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always-on file annotations #3115

Closed
Nicholas-Autio-Mitchell opened this issue Jan 20, 2024 · 4 comments
Closed

Always-on file annotations #3115

Nicholas-Autio-Mitchell opened this issue Jan 20, 2024 · 4 comments
Assignees
Labels
bug Something isn't working verified ✔ Verified
Milestone

Comments

@Nicholas-Autio-Mitchell
Copy link

Nicholas-Autio-Mitchell commented Jan 20, 2024

This is a follow-up to a previously posted (solved) issue: #1988

Summary: the git blame heat-map (rendered in the left git diff gutter) is not shown all the time -- it would be great to have a setting to ensure it is "aways on".

Currently, when opening a new VScode window or just a new repo, the blame heat-map must be toggled on while focus is on an open file (this works fine). Opening another file tracked by git, we see the blame heat-map appear after a few seonds (also works as expected). However if I close all git-tracked files e.g. whilst working on other files that are not yet git-tracked, and then open any git-tracked file, the blame heat-maps do not show up. They must be toggled on once again.

The setting I use for toggling is gitlens.toggleFileHeatmap, with a keybinding.

@eamodio for viz

@Nicholas-Autio-Mitchell Nicholas-Autio-Mitchell added feature New feature or request triage Needs to be looked at labels Jan 20, 2024
@eamodio eamodio changed the title Always-on git blame heatmap Always-on file annotations Jan 26, 2024
@eamodio eamodio added bug Something isn't working pending-release Resolved but not yet released to the stable edition needs-verification Request for verification and removed feature New feature or request triage Needs to be looked at labels Jan 26, 2024
@eamodio eamodio self-assigned this Jan 26, 2024
@eamodio eamodio added this to the 14.8 milestone Jan 26, 2024
@eamodio
Copy link
Member

eamodio commented Jan 26, 2024

Can you please verify this fix in tomorrow's (v2024.01.26xx) pre-release edition of GitLens? Thank you so much!

You can switch to the pre-release edition of GitLens, by clicking on the "Switch to Pre-Release version of this extension" from the Extensions view.

image

@Nicholas-Autio-Mitchell
Copy link
Author

Tested this in pre-release with version v2024.1.2604

Opening files, toggling gutter-blame to be active, then closing all files and re-opening: gutter-blame is still active. I would say this solves the issues as originally described 👍

One thing I have noticed now: when in editorFocus (cursor is active in an editor pane), with the gutter-blame active -- if I press Esc, the gutter-blame is deactivated. I am not sure by which mechanism this happens, but it requires re-toggling gutter-blame to be on and so breaks the "always on" gutter-blame I was hoping for.

@eamodio - I will let you decide if this is worth investigating/fixing; totally realise I am being super nit-picky here!

@eamodio
Copy link
Member

eamodio commented Jan 31, 2024

@Nicholas-Autio-Mitchell there is a relatively new setting gitlens.fileAnnotations.dismissOnEscape which can be disabled to turn off the ESC behavior.

I am wondering if that behavior should be the "default" if you set the annotation to be for the window (rather than per-file), but I'm not sure on that. I'd love to hear from you and others on that.

@eamodio eamodio added verified ✔ Verified and removed needs-verification Request for verification labels Jan 31, 2024
@d13 d13 removed the pending-release Resolved but not yet released to the stable edition label Feb 9, 2024
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working verified ✔ Verified
Projects
None yet
Development

No branches or pull requests

3 participants