From 9768dff54597e7566d4206545034fcdd3526eeb9 Mon Sep 17 00:00:00 2001 From: Siddhant Khare Date: Thu, 20 Feb 2025 15:48:15 +0000 Subject: [PATCH 1/4] fix: update Dockerfile to copy only package.json for installation --- .devcontainer/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile index 8ea34be..8424798 100644 --- a/.devcontainer/Dockerfile +++ b/.devcontainer/Dockerfile @@ -16,7 +16,7 @@ RUN ln -sf /usr/bin/yarnpkg /usr/bin/yarn WORKDIR /workspace -COPY package.json yarn.lock /workspace/ +COPY package.json /workspace/ RUN yarn install From 3679c969728eab7f27b2559a2fa340855c2f0dfe Mon Sep 17 00:00:00 2001 From: Siddhant Khare Date: Thu, 20 Feb 2025 15:55:07 +0000 Subject: [PATCH 2/4] nit fixes --- .devcontainer/devcontainer.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index d55fc4d..d4f8207 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -3,7 +3,8 @@ { "name": "Debian", "build": { - "dockerfile": "Dockerfile" + "dockerfile": "Dockerfile", + "context": ".." } // Features to add to the dev container. More info: https://containers.dev/features. From 7a89105271a0ebe029250efe4edb8e4c601570ec Mon Sep 17 00:00:00 2001 From: Siddhant Khare Date: Thu, 20 Feb 2025 16:02:06 +0000 Subject: [PATCH 3/4] fix: update Dockerfile to copy both package.json and yarn.lock for installation --- .devcontainer/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile index 8424798..8ea34be 100644 --- a/.devcontainer/Dockerfile +++ b/.devcontainer/Dockerfile @@ -16,7 +16,7 @@ RUN ln -sf /usr/bin/yarnpkg /usr/bin/yarn WORKDIR /workspace -COPY package.json /workspace/ +COPY package.json yarn.lock /workspace/ RUN yarn install From 201afc556424059939751ce4885ad383a308cf68 Mon Sep 17 00:00:00 2001 From: Siddhant Khare Date: Thu, 20 Feb 2025 16:16:18 +0000 Subject: [PATCH 4/4] Remove Dockerfile --- .devcontainer/Dockerfile | 23 ----------------------- .devcontainer/devcontainer.json | 23 ++++++----------------- 2 files changed, 6 insertions(+), 40 deletions(-) delete mode 100644 .devcontainer/Dockerfile diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile deleted file mode 100644 index 8ea34be..0000000 --- a/.devcontainer/Dockerfile +++ /dev/null @@ -1,23 +0,0 @@ -# syntax=docker/dockerfile:1 -FROM debian:bookworm-slim AS stainless - -RUN apt-get update && apt-get install -y \ - nodejs \ - npm \ - yarnpkg \ - && apt-get clean autoclean - -# Ensure UTF-8 encoding -ENV LANG=C.UTF-8 -ENV LC_ALL=C.UTF-8 - -# Yarn -RUN ln -sf /usr/bin/yarnpkg /usr/bin/yarn - -WORKDIR /workspace - -COPY package.json yarn.lock /workspace/ - -RUN yarn install - -COPY . /workspace diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index d4f8207..183f0d4 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -1,21 +1,10 @@ // For format details, see https://aka.ms/devcontainer.json. For config options, see the // README at: https://github.com/devcontainers/templates/tree/main/src/debian { - "name": "Debian", - "build": { - "dockerfile": "Dockerfile", - "context": ".." - } - - // Features to add to the dev container. More info: https://containers.dev/features. - // "features": {}, - - // Use 'forwardPorts' to make a list of ports inside the container available locally. - // "forwardPorts": [], - - // Configure tool-specific properties. - // "customizations": {}, - - // Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root. - // "remoteUser": "root" + "name": "Development", + "image": "mcr.microsoft.com/devcontainers/typescript-node:latest", + "features": { + "ghcr.io/devcontainers/features/node:1": {} + }, + "postCreateCommand": "yarn install" }