init task doesn't stop on failure

[abitrolly]

Bug description

Gitpod doesn't stop with an error when init task command fails.

Steps to reproduce

In the .gitpod.yml below (for Ruby project) gitpod/workspace-ruby-2 image comes without yarn, but init script continues to run after yarn install failed.

image: gitpod/workspace-ruby-2

tasks:
  - init: |
      bundle install
      yarn install --frozen-lockfile
      bundle exec rake
      bundle exec nanoc compile
    command: bundle exec nanoc live --port=3004

Workspace affected

abitrolly-gitlabdocs-1ymjgt70jro

Expected behavior

Failure and stopping after yarn install would make it much easier to spot and debug errors.

Example repository

https://gitlab.com/gitlab-org/gitlab-docs/ (it might be fixed soon)

Anything else?

No response

[axonasif]

Hi @abitrolly, all your tasks run inside separate bash (?$SHELL) shells. Gitpod can only assert the exit status of the $SHELL process. Normally bash or other shells don't halt on a failure of a command unless you explicitly ask it to. Since your last command bundle exec nanoc compile is not exiting with a non-zero code, so bash also inherits that before it's own exit. Hence Gitpod can't determine if all of your commands inside the init task succeeded. To have that effect, you can put set -e; on top of your init: | shell-commands to configure that particular task shell to halt and immediately exit with an error code for a failure of any command.

[abitrolly]

Hi @axonasif. Thanks for the explanation. I filled a request #13558 to invert the default behavior to what, I believe, most CI/CD users expect.