Technical debt: Re-unify AuthProviderInfo and AuthProviderEntry

[jankeromnes]

Is your feature request related to a problem? Please describe

We currently have two protocol shapes that are very similar:

gitpod/components/gitpod-protocol/src/protocol.ts

Lines 1142 to 1175 in 4e33131

	export interface AuthProviderInfo {
	readonly authProviderId: string;
	readonly authProviderType: string;
	readonly host: string;
	readonly ownerId?: string;
	readonly verified: boolean;
	readonly isReadonly?: boolean;
	readonly hiddenOnDashboard?: boolean;
	readonly loginContextMatcher?: string;
	readonly disallowLogin?: boolean;
	readonly icon?: string;
	readonly description?: string;
	readonly settingsUrl?: string;
	readonly scopes?: string[];
	readonly requirements?: {
	readonly default: string[];
	readonly publicRepo: string[];
	readonly privateRepo: string[];
	}
	}
	export interface AuthProviderEntry {
	readonly id: string;
	readonly type: AuthProviderEntry.Type;
	readonly host: string;
	readonly ownerId: string;
	readonly status: AuthProviderEntry.Status;
	readonly oauth: OAuth2Config;
	/** A random string that is to change whenever oauth changes (enforced on DB level) */
	readonly oauthRevision?: string;
	}

AuthProviderInfo vs AuthProviderEntry:

• authProviderId vs id
• authProviderType vs type
• host 👍
• ownerId 👍 (sometimes)
• verified = true vs status = "verified"
• (usage concerns) vs (oauth config)

Describe the behaviour you'd like

It would be great to re-unify them. 🧹 ✨

Describe alternatives you've considered

Additional context

For more context, see Slack thread (internal)

[jankeromnes]

Cross-posting this relevant comment from @andrew-farries:

[...] we should have a narrower type here than a string, ie a union like "GitHub" | "Gitlab" | ... .

[geropl]

@AlexTugarev I wondered the same before, but kept it as-is for velocities sake. I wonder if this make sense from you perspective (in general)?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.