Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code] update stable to 1.64 #8019

Merged
merged 1 commit into from
Feb 3, 2022
Merged

[code] update stable to 1.64 #8019

merged 1 commit into from
Feb 3, 2022

Conversation

jeanp413
Copy link
Member

@jeanp413 jeanp413 commented Feb 3, 2022

Description

Updates stable VS Code Web to 1.64
VSCode Endgame: microsoft/vscode#141298

Related Issue(s)

Fixes #

How to test

  • Select vscode stable in dashboard settings
  • Start a workspace.
  • Use about dialog to check that version is 1.64.

Release Notes

NONE

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #8019 (f438ffe) into main (19de806) will decrease coverage by 3.96%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             main   #8019      +/-   ##
=========================================
- Coverage   12.01%   8.04%   -3.97%     
=========================================
  Files          20      31      +11     
  Lines        1190    2212    +1022     
=========================================
+ Hits          143     178      +35     
- Misses       1043    2031     +988     
+ Partials        4       3       -1     
Flag Coverage Δ
components-gitpod-cli-app 10.86% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
installer-raw-app 5.63% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
installer/pkg/components/ws-manager/rolebinding.go 0.00% <0.00%> (ø)
...staller/pkg/components/ws-manager/networkpolicy.go 0.00% <0.00%> (ø)
installer/pkg/common/display.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/role.go 0.00% <0.00%> (ø)
installer/pkg/common/objects.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/configmap.go 30.05% <0.00%> (ø)
...components/ws-manager/unpriviledged-rolebinding.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/tlssecret.go 0.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19de806...f438ffe. Read the comment docs.

Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ :shipit:

image

@roboquat
Copy link
Contributor

roboquat commented Feb 3, 2022

LGTM label has been added.

Git tree hash: 062b662966a4be42a496d5ea29e000edd4d3c6db

@jeanp413
Copy link
Member Author

jeanp413 commented Feb 3, 2022

/approve no-issue

@roboquat
Copy link
Contributor

roboquat commented Feb 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filiptronicek, jeanp413

Associated issue requirement bypassed by: jeanp413

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit b2eb980 into main Feb 3, 2022
@roboquat roboquat deleted the jp/vscode-stable-1-64 branch February 3, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants