fix: remove unused loading state on medibox and add conditional rende…

…ring for mediaboxmodal
gitroomhq · Dec 4, 2024 · e5ab47f · e5ab47f
1 parent 955ef1b
commit e5ab47f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 14 deletions.
diff --git a/apps/frontend/src/components/media/mediabox.component.tsx b/apps/frontend/src/components/media/mediabox.component.tsx
@@ -7,7 +7,6 @@ import { TopTitle } from "../launches/helpers/top.title.component";
 import { MultipartFileUploader } from "./new.uploader";
 import clsx from "clsx";
 import { VideoFrame } from '@gitroom/react/helpers/video.frame';
-import { LoadingComponent } from "../layout/loading";
 import Image from "next/image";
 
 export const MediaBox: FC<{
@@ -20,8 +19,6 @@ export const MediaBox: FC<{
     const fetch = useFetch();
     const mediaDirectory = useMediaDirectory();
 
-    const [loading, setLoading] = useState(false);
-
     const loadMedia = useCallback(async () => {
       return (await fetch('/media')).json();
     }, [fetch]);
@@ -37,11 +34,9 @@ export const MediaBox: FC<{
     const { data, mutate } = useSWR('get-media', loadMedia);
 
     useEffect(() => {
-      setLoading(true)
       if (data?.results && data?.results?.length) {
         setListMedia([...data.results]);
       }
-      setLoading(false)
     }, [data]);
 
     return (
@@ -144,13 +139,6 @@ export const MediaBox: FC<{
                   )}
                 </div>
               ))}
-            {loading && (
-              <div className="w-[200px] h-[200px] flex border-tableBorder border-2 cursor-pointer relative">
-                <div className="absolute left-0 top-0 w-full h-full -mt-[50px] flex justify-center items-center">
-                  <LoadingComponent />
-                </div>
-              </div>
-            )}
           </div>
         </div>
       </div>

diff --git a/apps/frontend/src/components/media/mediaboxmodal.component.tsx b/apps/frontend/src/components/media/mediaboxmodal.component.tsx
@@ -31,9 +31,9 @@ export const ShowMediaBoxModal: FC = () => {
     }, []);
     if (!showModal) return null;
 
-    return (
+    return callBack && (
       <div className="text-textColor">
-        <MediaBox setMedia={callBack!} closeModal={closeModal} />
+        <MediaBox setMedia={callBack} closeModal={closeModal} />
       </div>
     );
   };