Skip to content
This repository has been archived by the owner on Dec 2, 2022. It is now read-only.

Fix Apple touch icon #818

Closed
nidamanx opened this issue Mar 30, 2017 · 7 comments
Closed

Fix Apple touch icon #818

nidamanx opened this issue Mar 30, 2017 · 7 comments
Assignees
Labels

Comments

@nidamanx
Copy link

-------------------------- layout/tiles/iosicons.php --------------------------
index d57cfd2..2e14380 100755
@@ -51,4 +51,4 @@ if (\theme_essential\toolbox::get_setting('ipadretinaicon')) {
-<link rel="apple-touch-icon-precomposed" sizes="57x57" href="<?php echo $iphoneicon ?>"/>
-<link rel="apple-touch-icon-precomposed" sizes="72x72" href="<?php echo $ipadicon ?>"/>
-<link rel="apple-touch-icon-precomposed" sizes="114x114" href="<?php echo $iphoneretinaicon ?>"/>
-<link rel="apple-touch-icon-precomposed" sizes="144x144" href="<?php echo $ipadretinaicon ?>"/>
\ No newline at end of file
+<link rel="apple-touch-icon" sizes="57x57" href="<?php echo $iphoneicon ?>"/>
+<link rel="apple-touch-icon" sizes="72x72" href="<?php echo $ipadicon ?>"/>
+<link rel="apple-touch-icon" sizes="114x114" href="<?php echo $iphoneretinaicon ?>"/>
+<link rel="apple-touch-icon" sizes="144x144" href="<?php echo $ipadretinaicon ?>"/>
@gjb2048
Copy link
Owner

gjb2048 commented Mar 30, 2017

Evidence please Davide of API change of 'apple-touch-icon-precomposed' to 'apple-touch-icon'.

@nidamanx
Copy link
Author

Hi Gareth. It seems a W3C suggestion. And anyway, Apple used that declaration on iOS2 (but now no one is using so old system)
https://validator.w3.org/nu/?doc=https%3A%2F%2Fwww.onlinelifeschool.com%2F#l114c262

@gjb2048
Copy link
Owner

gjb2048 commented Mar 31, 2017

Ok, but where is the evidence that the replacement is correct please?

@nidamanx
Copy link
Author

If you click on the link I gave you, you will see the W3C suggestion

@gjb2048
Copy link
Owner

gjb2048 commented Mar 31, 2017

But the site says "This tool is an ongoing experiment in better HTML checking, and its behavior remains subject to change" therefore could be a 'bug' and not a definitive definition of correctness for the value.

@nidamanx
Copy link
Author

nidamanx commented Apr 1, 2017

Yes, you're right, Gareth.
I trust in W3C so I searched for more info. I found something interesting in Apple.
https://developer.apple.com/library/content/documentation/AppleApplications/Reference/SafariWebContent/ConfiguringWebApplications/ConfiguringWebApplications.html
In that page is mentioned only:
<link rel="apple-touch-icon" ...>
and not:
<link rel="apple-touch-icon-precomposed" ...>

@gjb2048 gjb2048 changed the title fix <link rel="apple-touch-icon-precomposed" ...> to <link rel="apple-touch-icon" ...> Fix Apple touch icon Apr 1, 2017
gjb2048 added a commit that referenced this issue Apr 1, 2017
gjb2048 added a commit that referenced this issue Apr 1, 2017
@gjb2048 gjb2048 closed this as completed Apr 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants