New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Oidc integration #252

Closed

1 task done

JensAc opened this issue Aug 10, 2023 · 0 comments · Fixed by #253

Closed

1 task done

[Feature]: Oidc integration #252

JensAc opened this issue Aug 10, 2023 · 0 comments · Fixed by #253

Labels

Contributor

JensAc commented Aug 10, 2023

Checklist

I've searched for similar issues and couldn't find anything matching

Is this feature request related to a problem?

No

Problem Description

We want to configure an oidc provider for all applications spawned by the glasskube-operator.

Solution Description

A very simple solution would be to extend the app CRDs by e.g.

oidc:
  properties:
    name:
      type: string
    clientId:
      type: string
    clientSecret:
      type: string
    discoveryEndpoint:
      type: string
  type: object

and simply pass these additional bits of configuration to the apps.

Benefits

One could configure oidc without any manual interaction.

Potential Drawbacks

The resources would contain secret data, if the problem is approached as proposed. This might be acceptable for the sake of describing the app to be installed in a single resource. Of course, we could also think about specifying a secretRef and fetch the secret data from there. However, this would require the secret to exists, when an app should be installed.
What do you think?

Additional Information

No response

The text was updated successfully, but these errors were encountered:

JensAc added a commit to JensAc/operator that referenced this issue


          feat: Add oidc integration example for nextcloud (glasskube#252)

8ab3f42

Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>

JensAc added a commit to JensAc/operator that referenced this issue


          style: remove redundant comma (glasskube#252)

6acebb4

Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>

pmig linked a pull request

that will close this issue

feat: Add oidc integration example for nextcloud (#252) #253

Merged

kosmoz added enhancement apps/nextcloud and removed apps/nextcloud labels

JensAc added a commit to JensAc/operator that referenced this issue


          feat: Add oidc integration example for nextcloud (glasskube#252)

e1e865a

Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>

JensAc added a commit to JensAc/operator that referenced this issue


          style: remove redundant comma (glasskube#252)

8b1b000

Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>

JensAc added a commit to JensAc/operator that referenced this issue


          feat: Use oidc_login as oidc provider for nextcloud (glasskube#252)

314c780

Moreover, read clientId and clientSecret from a Kubernetes secret and
feed it into the nextcloud pod as an environment variable.

Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>

JensAc added a commit to JensAc/operator that referenced this issue


          docs: Add documentation for nextcloud oidc support (glasskube#252)

8bc1697

Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>

JensAc added a commit to JensAc/operator that referenced this issue


          style: remove redundant commas (glasskube#252)

111935c

Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>

JensAc added a commit to JensAc/operator that referenced this issue


          style: remove redundat safe call (glasskube#252)

5dcb9bb

Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>

JensAc added a commit to JensAc/operator that referenced this issue


          fix: define oidc spec as nullable (glasskube#252)

41e4774

Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>

JensAc added a commit to JensAc/operator that referenced this issue


          docs: Add description for oidcSecret (glasskube#252)

c715aaa

Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>

JensAc added a commit to JensAc/operator that referenced this issue


          style: Use spread operator instead of redundant safe calls (glasskube…

6c7762a

…#252)

Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>

JensAc added a commit to JensAc/operator that referenced this issue


          style: Use spread operator instead of redundant safe calls (glasskube…

e7ab565

…#252)

Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>

JensAc added a commit to JensAc/operator that referenced this issue


          feat: add oidc integration example for nextcloud (glasskube#252)

e4b517c

Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>

JensAc added a commit to JensAc/operator that referenced this issue


          style: remove redundant comma (glasskube#252)

abee1cc

Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>

JensAc added a commit to JensAc/operator that referenced this issue


          feat: use oidc_login as oidc provider for nextcloud (glasskube#252)

a24e2da

Moreover, read clientId and clientSecret from a Kubernetes secret and
feed it into the nextcloud pod as an environment variable.

Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>

JensAc added a commit to JensAc/operator that referenced this issue


          docs: add documentation for nextcloud oidc support (glasskube#252)

4e8feed

Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>

JensAc added a commit to JensAc/operator that referenced this issue


          style: remove redundant commas (glasskube#252)

be7b634

Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>

JensAc added a commit to JensAc/operator that referenced this issue


          style: remove redundat safe call (glasskube#252)

506a416

Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>

JensAc added a commit to JensAc/operator that referenced this issue


          fix: define oidc spec as nullable (glasskube#252)

7dc2a22

Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>

JensAc added a commit to JensAc/operator that referenced this issue


          docs: add description for oidcSecret (glasskube#252)

ee5831d

Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>

JensAc added a commit to JensAc/operator that referenced this issue


          style: use spread operator instead of redundant safe calls (glasskube…

e3b360f

…#252)

Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>

pmig closed this as completed in #253

pmig pushed a commit that referenced this issue


          feat: add oidc integration example for nextcloud (#252)

04ee6cf

Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>

pmig pushed a commit that referenced this issue


          style: remove redundant comma (#252)

80220a3

Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>

pmig pushed a commit that referenced this issue


          feat: use oidc_login as oidc provider for nextcloud (#252)

163bb99

Moreover, read clientId and clientSecret from a Kubernetes secret and
feed it into the nextcloud pod as an environment variable.

Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>

pmig pushed a commit that referenced this issue


          docs: add documentation for nextcloud oidc support (#252)

9f5987d

Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>

pmig pushed a commit that referenced this issue


          style: remove redundant commas (#252)

9c920ec

Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>

pmig pushed a commit that referenced this issue


          style: remove redundat safe call (#252)

72c4cbb

Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>

pmig pushed a commit that referenced this issue


          fix: define oidc spec as nullable (#252)

50f0199

Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>

pmig pushed a commit that referenced this issue


          docs: add description for oidcSecret (#252)

3d84955

Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>

pmig pushed a commit that referenced this issue


          style: use spread operator instead of redundant safe calls (#252)

fcc5d79

Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment