feat: Add oidc integration example for nextcloud (#252) #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution on the first glance it already looks very promissing. We might want to wrap the authentication into a parent object, so we can also support SAML2.0 and make it the interface future proof. Edit: As OICD is a separated app the configuration of a potential SAML 2.0 configuration can be in a different location. As @kosmoz will be able to review the PR next Wednesday the earliest it might take a little longer this time to get the interface right :-). |
1 task
kosmoz
requested changes
Aug 16, 2023
operator/src/main/kotlin/eu/glasskube/operator/apps/nextcloud/NextcloudAppsSpec.kt
Outdated
Show resolved
Hide resolved
operator/src/main/kotlin/eu/glasskube/operator/apps/nextcloud/NextcloudAppsSpec.kt
Show resolved
Hide resolved
operator/src/main/kotlin/eu/glasskube/operator/apps/nextcloud/dependent/NextcloudDeployment.kt
Outdated
Show resolved
Hide resolved
operator/src/main/kotlin/eu/glasskube/operator/apps/nextcloud/dependent/NextcloudDeployment.kt
Outdated
Show resolved
Hide resolved
operator/src/main/kotlin/eu/glasskube/operator/apps/nextcloud/dependent/NextcloudDeployment.kt
Outdated
Show resolved
Hide resolved
operator/src/main/kotlin/eu/glasskube/operator/apps/nextcloud/dependent/NextcloudDeployment.kt
Outdated
Show resolved
Hide resolved
JensAc
force-pushed
the
feat/oidc-integration
branch
from
6acebb4
to
8bc1697
Compare
|
I just iterated once more over this PR and hope that I met your ideas. Once again, I really appreciate a review and will iterate once more if desired. |
kosmoz
requested changes
Sep 11, 2023
There was a problem hiding this comment.
Thanks for the update!
I tested this feature using a local Keycloak and Nextcloud instance and it basically worked out of the box (see below)! ✨
There are still some smaller improvements/suggestions I would like to propose before we merge this (open for discussion, see below).
operator/src/main/kotlin/eu/glasskube/operator/apps/nextcloud/dependent/NextcloudConfigMap.kt
Outdated
Show resolved
Hide resolved
operator/src/main/kotlin/eu/glasskube/operator/apps/nextcloud/dependent/NextcloudDeployment.kt
Show resolved
Hide resolved
operator/src/main/kotlin/eu/glasskube/operator/apps/nextcloud/NextcloudAppsSpec.kt
Show resolved
Hide resolved
JensAc
force-pushed
the
feat/oidc-integration
branch
from
6c7762a
to
e7ab565
Compare
Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>
Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>
Moreover, read clientId and clientSecret from a Kubernetes secret and feed it into the nextcloud pod as an environment variable. Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>
Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>
Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>
Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>
Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>
Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>
…#252) Signed-off-by: Jens Schneider <jens.schneider.ac@posteo.de>
JensAc
force-pushed
the
feat/oidc-integration
branch
from
e7ab565
to
e3b360f
Compare
kosmoz
approved these changes
Sep 18, 2023
operator/src/main/kotlin/eu/glasskube/operator/apps/nextcloud/dependent/NextcloudDeployment.kt
Show resolved
Hide resolved
operator/src/main/kotlin/eu/glasskube/operator/apps/nextcloud/NextcloudAppsSpec.kt
Show resolved
Hide resolved
pmig
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a very simple example how the integration of oidc could be done. Please let me know what you think about having secret data directly in the
Nextcloudresource and theDeployment. This PR is meant as a starting point for discussion and implementation.