Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support consul new service meta #619

Closed
Wing924 opened this issue May 25, 2018 · 3 comments
Closed

Support consul new service meta #619

Wing924 opened this issue May 25, 2018 · 3 comments

Comments

@Wing924
Copy link

Wing924 commented May 25, 2018

Consul now support Service Meta since 1.0.7 hashicorp/consul#3881. It can store metadata like tags but using KV format. It's a good place to support attributes.

Tags and attributes are extra metadata fields for services. Not all backends support them. In fact, currently Consul supports tags and none support attributes.

We can store extra attributes to consul service meta.
@KRaFFiX
Copy link

KRaFFiX commented Jun 3, 2018

+1

1 similar comment
@dsouzajude
Copy link
Contributor

+1

@dsouzajude
Copy link
Contributor

I have a PR for this: #620

@dsouzajude dsouzajude mentioned this issue Jun 12, 2018
Merged
@Wing924 Wing924 closed this as completed Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dsouzajude @KRaFFiX @Wing924