From 0c81616abb3d6ec8926f77954eaf203e345f47b6 Mon Sep 17 00:00:00 2001 From: Chris Garrett Date: Sun, 10 May 2020 07:59:59 -0700 Subject: [PATCH 1/2] [REFACTOR] Remove unused EPOCH tag This tag doesn't appear to be used anymore, removing for now to clean things up and do less work on each dirty. --- packages/@glimmer/validator/index.ts | 1 - packages/@glimmer/validator/lib/tracking.ts | 3 --- 2 files changed, 4 deletions(-) diff --git a/packages/@glimmer/validator/index.ts b/packages/@glimmer/validator/index.ts index 6cacb531d0..dcc76eee4a 100644 --- a/packages/@glimmer/validator/index.ts +++ b/packages/@glimmer/validator/index.ts @@ -37,7 +37,6 @@ export { beginTrackFrame, endTrackFrame, consumeTag, - EPOCH, isTracking, track, trackedData, diff --git a/packages/@glimmer/validator/lib/tracking.ts b/packages/@glimmer/validator/lib/tracking.ts index a0fcb36f20..7e966c11ac 100644 --- a/packages/@glimmer/validator/lib/tracking.ts +++ b/packages/@glimmer/validator/lib/tracking.ts @@ -207,8 +207,6 @@ export function untrack(callback: () => void) { ////////// -export const EPOCH = createTag(); - export type Getter = (self: T) => T[K] | undefined; export type Setter = (self: T, value: T[K]) => void; @@ -240,7 +238,6 @@ export function trackedData( assertTagNotConsumed!(tagFor(self, key), self, key, true); } - dirtyTag(EPOCH); dirtyTagFor(self, key); values.set(self, value); } From 3cbb49678a37f48bb9430ff7bff7f1d55c582df1 Mon Sep 17 00:00:00 2001 From: Chris Garrett Date: Sun, 10 May 2020 08:08:36 -0700 Subject: [PATCH 2/2] update imports --- packages/@glimmer/validator/lib/tracking.ts | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/packages/@glimmer/validator/lib/tracking.ts b/packages/@glimmer/validator/lib/tracking.ts index 7e966c11ac..29fca93687 100644 --- a/packages/@glimmer/validator/lib/tracking.ts +++ b/packages/@glimmer/validator/lib/tracking.ts @@ -1,14 +1,5 @@ import { DEBUG } from '@glimmer/env'; -import { - Tag, - combine, - createTag, - dirtyTag, - CONSTANT_TAG, - validateTag, - Revision, - valueForTag, -} from './validators'; +import { Tag, combine, CONSTANT_TAG, validateTag, Revision, valueForTag } from './validators'; import { tagFor, dirtyTagFor } from './meta'; import { markTagAsConsumed, runInAutotrackingTransaction, assertTagNotConsumed } from './debug';