From 9c480ca4e37ae63f10bd1a28311b80325b928bc2 Mon Sep 17 00:00:00 2001 From: Alex Kanunnikov Date: Tue, 5 Dec 2023 18:36:27 +0300 Subject: [PATCH] [perf] remove extra combine logic --- packages/@glimmer/validator/lib/tracking.ts | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/packages/@glimmer/validator/lib/tracking.ts b/packages/@glimmer/validator/lib/tracking.ts index b8426b0cb3..1182038add 100644 --- a/packages/@glimmer/validator/lib/tracking.ts +++ b/packages/@glimmer/validator/lib/tracking.ts @@ -11,7 +11,6 @@ import { combine, CONSTANT_TAG, isConstTag, validateTag, valueForTag } from './v */ class Tracker { private tags = new Set(); - private last: Tag | null = null; add(tag: Tag) { if (tag === CONSTANT_TAG) return; @@ -21,20 +20,10 @@ class Tracker { if (import.meta.env.DEV) { unwrap(debug.markTagAsConsumed)(tag); } - - this.last = tag; } combine(): Tag { - let { tags } = this; - - if (tags.size === 0) { - return CONSTANT_TAG; - } else if (tags.size === 1) { - return this.last as Tag; - } else { - return combine(Array.from(this.tags)); - } + return combine(Array.from(this.tags)); } }