Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import of sass files without extension containing multiple dots (like common.mixins.scss) #166

Closed
olte36 opened this issue Feb 3, 2024 · 1 comment

Comments

@olte36
Copy link
Contributor

olte36 commented Feb 3, 2024

Hello,

I've found an issue, when a sass file imports another sass file without .scss or other extension and it has multiple dots in its name like

// common.mixins.scss
$_padding: 10px;

@mixin padded {
    padding: $_padding;
}

// index.scss
@use "./common.mixins" as c;

body {
  @include c.padded;
}

The plugin throws an error that it cannot find common.mixins because it treats .mixins as an extension.

I decided to fix it myself, please check my PR 😃
#167

@olte36 olte36 changed the title Fix import of sass files without extension containing miltiple dots like app.component.scss Fix import of sass files without extension containing multiple dots (like common.mixins.scss) Feb 3, 2024
@olte36 olte36 changed the title Fix import of sass files without extension containing multiple dots (like common.mixins.scss) Import of sass files without extension containing multiple dots (like common.mixins.scss) Feb 3, 2024
glromeo added a commit that referenced this issue Feb 3, 2024
Issue #166 Fix import of sass files without extension containing multiple dots (like common.mixins.scss)
@glromeo
Copy link
Owner

glromeo commented Feb 3, 2024

That's the spirit mate!

Thank you very much for your contribution I will kick off a new build soon

@glromeo glromeo closed this as completed Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants