Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper dialog for plotly export #1057

Merged
merged 13 commits into from
Jul 30, 2016

Conversation

astrofrog
Copy link
Member

@astrofrog astrofrog commented Jul 29, 2016

This supports selecting the sharing privileges, and the account to export to:

screen shot 2016-07-29 at 5 53 16 pm

This still needs:

  • Changelog
  • Tests
  • Remove 'enter a label' dialog

…ng privileges, and the account to export to.
@astrofrog astrofrog added this to the v0.9.0 milestone Jul 29, 2016
@sbussmann
Copy link

That looks good to me. Is the username automatically detected and displayed in the pop-up dialog? Or do all users just get astrofrog as an example username?

Also, there's typo: "Plotly usng secret URLs..." --> "Plotly using secret URLs"

@astrofrog
Copy link
Member Author

That looks good to me. Is the username automatically detected and displayed in the pop-up dialog? Or do all users just get astrofrog as an example username?

It loads the username from the .plotly/.credentials file if present

Thanks for spotting the typo! Currently working on the tests and will fix that at the same time.

@sbussmann
Copy link

Ok, looks good to me! Nice work!

@astrofrog astrofrog merged commit f8eddd2 into glue-viz:master Jul 30, 2016
@astrofrog
Copy link
Member Author

@sbussmann - this is now merged - let me know if you try it out at some point. This will be included in the 0.9.0 release which is a few weeks away, but you can use the developer version of glue in the mean time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants