-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proper dialog for plotly export #1057
Conversation
…ng privileges, and the account to export to.
That looks good to me. Is the username automatically detected and displayed in the pop-up dialog? Or do all users just get astrofrog as an example username? Also, there's typo: "Plotly usng secret URLs..." --> "Plotly using secret URLs" |
It loads the username from the .plotly/.credentials file if present Thanks for spotting the typo! Currently working on the tests and will fix that at the same time. |
Ok, looks good to me! Nice work! |
@sbussmann - this is now merged - let me know if you try it out at some point. This will be included in the 0.9.0 release which is a few weeks away, but you can use the developer version of glue in the mean time. |
This supports selecting the sharing privileges, and the account to export to:
This still needs: