Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2d vector field tab to the scatter plot viewer #1410

Merged
merged 9 commits into from
Oct 19, 2017

Conversation

PennyQ
Copy link
Contributor

@PennyQ PennyQ commented Oct 1, 2017

As shown below, vx and vy are arrow vectors, the arrow dimensions (except for length) are measured in multiples of the square root of x square plus y square, ref to matplotlib_quiver definition.

photo_2017-10-01_16-23-25

@PennyQ
Copy link
Contributor Author

PennyQ commented Oct 2, 2017

The test failed because of astropy_table as below:

glue/core/data_exporters/tests/test_astropy_table.py::test_astropy_table[ascii.ipac] FAILED
glue/core/data_exporters/tests/test_astropy_table.py::test_astropy_table[ascii.latex] FAILED

@astrofrog
Copy link
Member

@PennyQ - thanks for working on this! I wonder whether it would be good to have an option to select length and angle instead of vx/vy (I think both would be useful). Also can you add a checkbox to control whether to show the arrow heads?

@PennyQ
Copy link
Contributor Author

PennyQ commented Oct 3, 2017

@astrofrog The hide arrow and angle/length options are added within the new PR. As you can see below, please let me know anything else can be improved :)

photo_2017-10-03_12-00-12

@astrofrog
Copy link
Member

I rebased this as I think it may fix the failing tests

@astrofrog
Copy link
Member

@PennyQ - I fixed the issues, and this looks good, so merging! I'll tweak the UI of this and other things in the scatter plot viewer in a separate pull request.

@astrofrog astrofrog merged commit fa39187 into glue-viz:master Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants