Use mode='denywrite' in FITS data factory #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1884 +/- ##
==========================================
+ Coverage 85.5% 85.68% +0.17%
==========================================
Files 235 235
Lines 20875 21087 +212
==========================================
+ Hits 17850 18068 +218
+ Misses 3025 3019 -6
Continue to review full report at Codecov.
|
This is because the default mode ('readonly') results in files being opened with mmap with the ACCESS_COPY flag, which doesn't work properly on some platforms when the available address space is less than the file size.
astrofrog
force-pushed
the
fits-denywrite
branch
from
245bede to
22e9d4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because the default mode ('readonly') results in files being opened with mmap with the ACCESS_COPY flag, which doesn't work properly on some platforms when the available address space is less than the file size.
cc @Cadair