Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with reading in VO Tables #1911

Merged
merged 4 commits into from
Jan 8, 2019
Merged

Conversation

astrofrog
Copy link
Member

Due to a change in either Numpy or Astropy (haven't had a chance to investigate which), reading of VO Tables with non-float columns was broken. This PR fixes this.

Fixes #1910

@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #1911 into master will decrease coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1911      +/-   ##
=========================================
- Coverage   85.62%   85.5%   -0.12%     
=========================================
  Files         236     236              
  Lines       21042   21042              
=========================================
- Hits        18017   17993      -24     
- Misses       3025    3049      +24
Impacted Files Coverage Δ
glue/core/data_factories/astropy_table.py 91.66% <100%> (+3.33%) ⬆️
glue/conftest.py 58% <0%> (-12%) ⬇️
glue/utils/qt/app.py 86.04% <0%> (-9.31%) ⬇️
glue/core/data_factories/pandas.py 83.01% <0%> (-3.78%) ⬇️
glue/app/qt/preferences.py 91.01% <0%> (-3.38%) ⬇️
glue/_settings_helpers.py 91.17% <0%> (-2.95%) ⬇️
glue/viewers/matplotlib/layer_artist.py 95% <0%> (-2.5%) ⬇️
glue/plugins/exporters/plotly/export_plotly.py 73.71% <0%> (-1.29%) ⬇️
glue/app/qt/application.py 77.77% <0%> (-0.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06ad71c...2d16898. Read the comment docs.

@astrofrog
Copy link
Member Author

The Travis failure is unrelated

@astrofrog astrofrog merged commit 6e56413 into glue-viz:master Jan 8, 2019
astrofrog added a commit that referenced this pull request Feb 4, 2019
Fix issue with reading in VO Tables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't open demo data file w5_psc.vot
1 participant