Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile Viewer Script Export #2082

Merged
merged 5 commits into from
Apr 2, 2020
Merged

Conversation

jsub1
Copy link
Contributor

@jsub1 jsub1 commented Feb 6, 2020

Addresses #1644 by adding the ability to export the profile viewer to a python script.

@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #2082 into master will increase coverage by 0.00%.
The diff coverage is 97.14%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #2082    +/-   ##
========================================
  Coverage   87.98%   87.98%            
========================================
  Files         244      245     +1     
  Lines       22269    22419   +150     
========================================
+ Hits        19594    19726   +132     
- Misses       2675     2693    +18     
Impacted Files Coverage Δ
glue/viewers/profile/python_export.py 96.66% <96.66%> (ø)
glue/plugins/tools/__init__.py 100.00% <100.00%> (ø)
glue/viewers/profile/layer_artist.py 95.83% <100.00%> (+0.08%) ⬆️
glue/app/qt/application.py 79.20% <0.00%> (+0.70%) ⬆️
glue/viewers/profile/viewer.py 94.73% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b29d3f...3c4e682. Read the comment docs.

@astrofrog astrofrog self-requested a review March 3, 2020 14:47
@astrofrog
Copy link
Member

@jsub1 - can you rebase this as the tests should now pass on master?

@astrofrog astrofrog force-pushed the ProfileViewerExport branch from 53cb3b2 to 3c4e682 Compare April 2, 2020 17:00
@astrofrog astrofrog added this to the v0.16.0 milestone Apr 2, 2020
Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great, thanks! 👍

@astrofrog astrofrog merged commit d3103bf into glue-viz:master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants