Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wrong Unit on Slider for Images #2159

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Conversation

jsub1
Copy link
Contributor

@jsub1 jsub1 commented Jul 7, 2020

Fix for #2132. The issue was that we had to flip the index when looking up the string for the unit.

@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #2159 into master will increase coverage by 0.00%.
The diff coverage is 84.14%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2159   +/-   ##
=======================================
  Coverage   87.86%   87.86%           
=======================================
  Files         246      246           
  Lines       22708    22709    +1     
=======================================
+ Hits        19952    19954    +2     
+ Misses       2756     2755    -1     
Impacted Files Coverage Δ
glue/viewers/matplotlib/state.py 90.18% <79.54%> (ø)
glue/viewers/matplotlib/viewer.py 93.92% <85.71%> (ø)
glue/viewers/histogram/qt/options_widget.py 87.09% <100.00%> (ø)
glue/viewers/image/qt/options_widget.py 84.00% <100.00%> (ø)
glue/viewers/image/qt/slice_widget.py 72.63% <100.00%> (+0.29%) ⬆️
glue/viewers/profile/qt/options_widget.py 100.00% <100.00%> (ø)
glue/viewers/scatter/qt/options_widget.py 89.74% <100.00%> (ø)
glue/utils/qt/helpers.py 55.05% <0.00%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fcd828...3579140. Read the comment docs.

Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops thanks!

@astrofrog astrofrog merged commit 1b06d35 into glue-viz:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants