Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assumption that all layer artists have a zorder #2226

Merged
merged 2 commits into from
Aug 20, 2021

Conversation

astrofrog
Copy link
Member

I think it is sufficient to ignore the callback on state.zorder which should exist.

@astrofrog astrofrog added the bug label Aug 20, 2021
@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #2226 (8e128fa) into master (5978a92) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2226   +/-   ##
=======================================
  Coverage   88.03%   88.04%           
=======================================
  Files         247      247           
  Lines       23168    23164    -4     
=======================================
- Hits        20396    20394    -2     
+ Misses       2772     2770    -2     
Impacted Files Coverage Δ
glue/app/qt/layer_tree_widget.py 80.59% <ø> (+0.36%) ⬆️
glue/viewers/common/viewer.py 90.76% <100.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5978a92...8e128fa. Read the comment docs.

@astrofrog astrofrog changed the title Fix assumption that all layer aritsts have a zorder Fix assumption that all layer artists have a zorder Aug 20, 2021
@astrofrog astrofrog merged commit d18f722 into glue-viz:master Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant