Allow specifying visual attributes and colormap when faceting subsets #2350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carifio24
force-pushed
the
facet-visual-attrs
branch
from
2794244 to
eb451c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds arguments to
facet_subsetsto allow directly specifying subset styling and a colormap from that function call (as opposed to callingcolorize_subsetsafter, as the dialog currently does. This PR also updates the subset faceting dialog to use the updated function signature, though it doesn't expose the styling options to the UI (though there's no reason that we couldn't).I think there are a few use cases here. Subset faceting via the dialog should see a slight performance increase with a large number of subsets, since we no longer need another pass through to update colors. Dashboard-style applications could similarly benefit from this to avoid the quick re-rendering that inspired augmenting
new_subsetandnew_subset_group. I could also see a tool or plugin that does automatic faceting benefiting from this as well.