Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use fancy index for subsets over Dask data #2444

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

jfoster17
Copy link
Member

Pull Request Template

Description

Fix FRB so that we can reliably compute subsets over data with Dask components.

@astrofrog astrofrog force-pushed the fix-frb-subsets-for-dask branch from c576b50 to 9fd1fe2 Compare September 21, 2023 20:45
Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased to get rid of the merge commit, but looks good to me otherwise! Let's merge if CI passes.

@jfoster17 jfoster17 merged commit 90955df into glue-viz:main Sep 22, 2023
21 checks passed
@jfoster17 jfoster17 deleted the fix-frb-subsets-for-dask branch October 31, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants