-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented plugin manager #682
Conversation
@ChrisBeaumont - this is ready for review if you are interested |
Looks good to me! On Sunday, July 5, 2015, Thomas Robitaille notifications@github.com wrote:
|
I think I'll need to add some tests for this, will do this week. |
f3d69be
to
826763b
Compare
This now includes unit tests, and also implements a way to override the config dir during tests (in fact, it's overridden by default by a temp directory and can be further overridden by individual tests) |
Ok, this is ready for a proper review. One open question is how to deal with plugins and session files. If I use a plugin and save a session which contains a reference to that plugin, then load the session up, should it load the required plugins even if the required plugins were disabled before? Should it give an error? What about plugins that aren't even installed? |
@ChrisBeaumont - would you like to review this before I merge? Do you have any thoughts about the question of saving sessions that use plugins? |
This looks good to me. Can we attempt to load saved plugins, with graceful On Saturday, July 18, 2015, Thomas Robitaille notifications@github.com
|
e543b13
to
8fc54aa
Compare
…d ensure plugins are loaded when pytest is first run.
… and get the test to work on Windows.
6933e1d
to
6ea3143
Compare
For the loading of plugins when restoring sessions, I've opened this issue: #721 (since this is an issue that is independent on this PR) |
A simple GUI will follow (in this PR). Plugins are enabled unless explicitly disabled.