Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented plugin manager #682

Merged
merged 13 commits into from
Aug 16, 2015
Merged

Conversation

astrofrog
Copy link
Member

A simple GUI will follow (in this PR). Plugins are enabled unless explicitly disabled.

@astrofrog astrofrog added this to the 0.6 milestone Jul 3, 2015
@astrofrog
Copy link
Member Author

This now implements a GUI manager for plugins:

screen shot 2015-07-05 at 11 08 23 pm

Users need to restart Glue for changes to take effect, but otherwise it works as expected.

(oops just realized window title is wrong, fixing)

@astrofrog astrofrog changed the title Initial steps for plugin management Implemented plugin manager Jul 5, 2015
@astrofrog
Copy link
Member Author

@ChrisBeaumont - this is ready for review if you are interested

@ChrisBeaumont
Copy link
Member

Looks good to me!

On Sunday, July 5, 2015, Thomas Robitaille notifications@github.com wrote:

@ChrisBeaumont https://github.com/ChrisBeaumont - this is ready for
review if you are interested


Reply to this email directly or view it on GitHub
#682 (comment).

@astrofrog
Copy link
Member Author

I think I'll need to add some tests for this, will do this week.

@astrofrog astrofrog force-pushed the plugin-management branch from f3d69be to 826763b Compare July 10, 2015 06:39
@astrofrog
Copy link
Member Author

This now includes unit tests, and also implements a way to override the config dir during tests (in fact, it's overridden by default by a temp directory and can be further overridden by individual tests)

@astrofrog
Copy link
Member Author

Ok, this is ready for a proper review.

One open question is how to deal with plugins and session files. If I use a plugin and save a session which contains a reference to that plugin, then load the session up, should it load the required plugins even if the required plugins were disabled before? Should it give an error? What about plugins that aren't even installed?

@astrofrog
Copy link
Member Author

@ChrisBeaumont - would you like to review this before I merge? Do you have any thoughts about the question of saving sessions that use plugins?

@ChrisBeaumont
Copy link
Member

This looks good to me. Can we attempt to load saved plugins, with graceful
fallback if they aren't available?

On Saturday, July 18, 2015, Thomas Robitaille notifications@github.com
wrote:

@ChrisBeaumont https://github.com/ChrisBeaumont - would you like to
review this before I merge? Do you have any thoughts about the question of
saving sessions that use plugins?


Reply to this email directly or view it on GitHub
#682 (comment).

@astrofrog astrofrog force-pushed the plugin-management branch 2 times, most recently from e543b13 to 8fc54aa Compare August 8, 2015 16:23
@astrofrog
Copy link
Member Author

For the loading of plugins when restoring sessions, I've opened this issue: #721 (since this is an issue that is independent on this PR)

astrofrog added a commit that referenced this pull request Aug 16, 2015
@astrofrog astrofrog merged commit 1c43c1d into glue-viz:master Aug 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants