Improvements to widget properties #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CurrentComboProperty has been renamed to CurrentComboDataProperty and CurrentComboTextProperty has been added, to differentiate between cases where the item should be selected based on the text vs data in the combo box. In addition, this adds the ability to define a mapping function for value-based properties. Finally, this adds CurrentTabProperty. The tests have been expanded to cover all widget properties.
|
|
||
| class CurrentComboTextProperty(WidgetProperty): | ||
| """ | ||
| Wrapper around ComboBoxes |
There was a problem hiding this comment.
differentiate docstrings here?
|
This looks good
That sounds right. I guess we could make it so that callbacks could more easily be attached to WidgetProperties directly (ie maybe WidgetProperty should inherit from CallbackProperty) |
astrofrog
added a commit
that referenced
this pull request
Oct 6, 2015
Improvements to widget properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several changes in this pull request, following work on the 3-d viewer:
CurrentComboPropertyhas been renamed toCurrentComboDataPropertyandCurrentComboTextPropertyhas been added, to differentiate between cases where the item should be selected based on the text vs data in the combo box (note that for backward-compatibility,CurrentComboPropertyis set toCurrentComboDataProperty)CurrentTabProperty. The tests have been expanded to cover all widget properties.test_widget_properties.pyto test all functions/classes@ChrisBeaumont - am I right in thinking that when one doesn't need an actual callback, but instead just needs the property to be set when called, then the widget properties should be used, whereas if an immediate callback is needed, the callback properties and connect functions should be used?