-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh plot after resizing image widget #768
Conversation
8059ced
to
894addc
Compare
919549a
to
2edb6e7
Compare
I've disabled the regression test on OS X on Travis since for some reason the timer never appears to trigger the timeout. However, things work fine and the test works on my actual OS X desktop, so this is a peculiarity of Travis and might be related to multi-threading. @ChrisBeaumont - if you have any ideas what this could be, let me know, but in the mean time I plan to merge things once Travis (Linux) and AppVeyor pass. |
e69f4cf
to
aef3608
Compare
This also fails on Windows and on top of that, we're now seeing some unrelated Travis issues linked to conda package updates. |
23af8a5
to
5ce85f8
Compare
Which timer are you referring to here? I assume I shouldn't be looking at the diff too closely at the moment, since it seems to be deleting lots of code. |
c610ac6
to
ed65bf3
Compare
@ChrisBeaumont - yes, sorry, am in the middle of debugging. The issue seems to be that under certain circumstances, the QTimer for resize_timer doesn't fire off resize_end. I'm currently investigating... |
27e01e1
to
7d94952
Compare
66f80b8
to
6cb5679
Compare
I've given up debugging for now, there are several issues clouding this, in particular the fact that when debugging, I found that the success of this test depends on whether other Qt tests were run before, so this makes things very confusing. For now, I'll skip the tests on Travis OSX and AppVeyor and get the fix in. |
I'm going to go ahead and merge this since the fix is important, and the regression test does work locally and on Travis with Linux. I can open another issue to keep track of the problem. |
Refresh plot after resizing image widget
This fixes a bug that caused images to be heavily pixellated after a resizing, and only updating if the user clicked in the canvas.