Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh plot after resizing image widget #768

Merged
merged 6 commits into from
Oct 22, 2015

Conversation

astrofrog
Copy link
Member

This fixes a bug that caused images to be heavily pixellated after a resizing, and only updating if the user clicked in the canvas.

@astrofrog
Copy link
Member Author

I've disabled the regression test on OS X on Travis since for some reason the timer never appears to trigger the timeout. However, things work fine and the test works on my actual OS X desktop, so this is a peculiarity of Travis and might be related to multi-threading.

@ChrisBeaumont - if you have any ideas what this could be, let me know, but in the mean time I plan to merge things once Travis (Linux) and AppVeyor pass.

@astrofrog
Copy link
Member Author

This also fails on Windows and on top of that, we're now seeing some unrelated Travis issues linked to conda package updates.

@astrofrog astrofrog force-pushed the refresh-draw branch 3 times, most recently from 23af8a5 to 5ce85f8 Compare October 21, 2015 20:07
@ChrisBeaumont
Copy link
Member

I've disabled the regression test on OS X on Travis since for some reason the timer never appears to trigger the timeout.

Which timer are you referring to here?

I assume I shouldn't be looking at the diff too closely at the moment, since it seems to be deleting lots of code.

@astrofrog astrofrog force-pushed the refresh-draw branch 2 times, most recently from c610ac6 to ed65bf3 Compare October 21, 2015 21:12
@astrofrog
Copy link
Member Author

@ChrisBeaumont - yes, sorry, am in the middle of debugging. The issue seems to be that under certain circumstances, the QTimer for resize_timer doesn't fire off resize_end. I'm currently investigating...

@astrofrog
Copy link
Member Author

I've given up debugging for now, there are several issues clouding this, in particular the fact that when debugging, I found that the success of this test depends on whether other Qt tests were run before, so this makes things very confusing. For now, I'll skip the tests on Travis OSX and AppVeyor and get the fix in.

@astrofrog
Copy link
Member Author

I'm going to go ahead and merge this since the fix is important, and the regression test does work locally and on Travis with Linux. I can open another issue to keep track of the problem.

astrofrog added a commit that referenced this pull request Oct 22, 2015
Refresh plot after resizing image widget
@astrofrog astrofrog merged commit f8d36d9 into glue-viz:master Oct 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants