Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for math and numpy modules in 'new component' window #956

Merged
merged 6 commits into from
May 3, 2016

Conversation

astrofrog
Copy link
Member

@astrofrog astrofrog commented Apr 19, 2016

Also improve layout of window and add instructions.

To-do:

  • evaluate expression on-the-fly for single data element to check for syntax issues
  • emit errors/warnings inside window instead of with separate pop-ups
  • only allow to click OK once everything is set properly

@astrofrog
Copy link
Member Author

Just need to add a test for evaluate_test before I merge

@astrofrog astrofrog force-pushed the improved-new-component branch from 547ea05 to 3d9f0cf Compare May 2, 2016 22:09
astrofrog added 6 commits May 3, 2016 15:24
…sion, and don’t allow user to create a component with an invalid expression. Also make sure that the error windows relating to e.g. a missing label for the new component or a missing target dataset are raised without closing and reopening the dialog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant