feat: alias Ctrl to Control when parsing keybindings
#338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lars-berger
changed the title
Ctrl to Control when parsing keybindings
|
Thank you for this 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny PR here.
I grabbed some low-hanging fruit from the "Free to take" list. https://github.com/users/lars-berger/projects/2/views/1?pane=issue&itemId=28116872
I chose to implement this with a switch so that more keybinding aliasing could be done quickly in future (e.g. Meta -> Alt)
Ignore the completely overwritten first commit, I decided as I was drafting this PR that it'd be better to check against the Enum first before moving on to the switch so there's not a whole bunch of unnecessary comparisons.