Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some property names are misleading #289

Open
ehx-v1 opened this issue Apr 13, 2023 · 2 comments
Open

Some property names are misleading #289

ehx-v1 opened this issue Apr 13, 2023 · 2 comments

Comments

@ehx-v1
Copy link

ehx-v1 commented Apr 13, 2023

...due to describing features that are already in the game (but done differently by the property).

To clarify: This is not to discredit the property options as good alternatives. It's just that the name can be confusing to some players (if they don't read the Readme), who might think setting them to false disables the Vanilla option whereas in reality, setting them to true enables a new option.

The affected properties:

  • renewableIce: Both ice itself (by placing water at a high Y level or in a cold biome and letting it freeze) and dense forms of ice (by crafting them from 4 of the respective less dense form) are renewable. Proposed name: betterRenewableIce
  • renewableSand: Sand is technically already renewable through the Wandering Trader. While the option from Carpet Extras is actually viable whereas the Wandering Trader option isn't, it can still be misleading. Proposed name: betterRenewableSand
  • renewableWitherSkeletons: Wither Skeletons spawn repeatedly in Nether Fortresses. This case is unique in that the added option isn't significantly more viable than the Vanilla option (although it still feels like a good and fitting idea). Proposed name: electricWitherSkeletons
@altrisi
Copy link
Collaborator

altrisi commented Jul 25, 2023

The problem is that renaming them would mean that any worlds that have them enabled would get them disabled, likely breaking stuff in them.

There's currently no system to automatically migrate rules to new names.

@ehx-v1
Copy link
Author

ehx-v1 commented Jul 26, 2023

Well, that just means the issue is dependant on establishing such a system (e.g. an API version setup with backwards compatibility mixins) beforehand. Such a system would probably be helpful either way, as being able to rename properties between versions is a major plus in general. Plus, it's not like this issue is very likely to be high priority, so taking your time really is an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants