Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refinement of gno precompile and build commands. #1242

Closed
moul opened this issue Oct 12, 2023 · 1 comment · Fixed by #1297
Closed

Refinement of gno precompile and build commands. #1242

moul opened this issue Oct 12, 2023 · 1 comment · Fixed by #1297
Assignees
@tbruyelle

Comments

@moul
Copy link
Member

moul commented Oct 12, 2023 •
edited
Loading

  1. Deprecate: gno build subcommand.
  2. Add: --build or --try-build flag to gno precompile for building post-precompilation.
  3. Ensure: Recursive precompilation of imports.

This will enhance the ecosystem by precompiling and testing the precompilation using go build in the precompile subcommand ecosystem.

Note: I intend to utilize the build subcommand for other beneficial purposes later.
@moul moul moved this to 🔵 Not Needed for Launch in 🚀 The Launch [DEPRECATED] Oct 12, 2023
@moul
Copy link
Member Author

moul commented Oct 12, 2023

cc @tbruyelle

@tbruyelle tbruyelle self-assigned this Oct 25, 2023
tbruyelle added a commit to tbruyelle/gno that referenced this issue Oct 25, 2023
@tbruyelle
refac!: remove gno build command
9bad6cb 
Closes: gnolang#1242

In favor of `gno precompile --build`
@tbruyelle tbruyelle mentioned this issue Oct 26, 2023
Merged
7 tasks
tbruyelle added a commit to tbruyelle/gno that referenced this issue Oct 26, 2023
@tbruyelle
refac!: remove gno build command
5d27a41 
Closes: gnolang#1242

In favor of `gno precompile --build`
tbruyelle added a commit to tbruyelle/gno that referenced this issue Nov 16, 2023
@tbruyelle
refac!: remove gno build command
06d74d3 
Closes: gnolang#1242

In favor of `gno precompile --build`
thehowl pushed a commit that referenced this issue Nov 16, 2023
@tbruyelle
refactor!: remove gno build command (#1297)
0c68394 
Closes: #1242

In favor of `gno precompile -gobuild`. 

As seen in the tests written for `gno build` in this PR #1103, the
command's behavior is kinda unexpected. It actually doesn't care about
the syntax of gno files and only relies on go files found in the path
passed as an argument.

Because of that, I chose to name the flag `-gobuild` instead of `-build`
because I found that represents better what's really happening when this
flag is provided.

As mentioned in the linked issue, `gno build` will be re-implemented in
the future with an other behavior.

<!-- please provide a detailed description of the changes made in this
pull request. -->

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
harry-hov added a commit to harry-hov/gnopls that referenced this issue Jan 5, 2024
@harry-hov
Remove gno build command
00aff27 
`gno build` has been removed from gno binary in PR[1]. Removed usage
of same in the language server.

Using `gno precompile -gobuild` instead.

See:
[1]: gnolang/gno@0c68394)
[2]: gnolang/gno#1242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbruyelle tbruyelle

Labels
None yet
Projects
🚀 The Launch [DEPRECATED]
Status: 🔵 Not Needed for Launch
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: remove gno build command tbruyelle/gno
2 participants
@tbruyelle @moul