-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keplr wallet to help page #154
Conversation
Awesome I will get to it asap! |
8474fd2
to
1a86aef
Compare
we need to enable cors in rpc |
@giansalex, what's the current step? do you need a review/final review or do you want some more time to make changes? (the PR is in draft mode) |
346d62d
to
f19563d
Compare
Hey @moul, code is ready, but it will be necessary to enable CORS in gno.land:36657 I also sent a pull request to keplr repo, chainapsis/keplr-wallet#392 Here is a guide to install the dev version. |
some pending issues (for keplr pr).
|
That's awesome @giansalex 👍👍👍
Can you help list the CORS restrictions we can add, i.e., which headers, methods, origins, etc?
Are you okay that we merge your PR and open an issue with all the ongoing things to do, or do you prefer to make an atomic PR with everything inside?
I suggest:
if you don't do it, I'm sure someone else will, so no problem :) Once again, congratulations for your work! |
gnoland/website/static/js/wallet.js
Outdated
chainId: chainId, | ||
chainName: "GNO Testnet", | ||
rpc: 'http://gno.land:36657', | ||
rest: 'https://lcd.gno.tools', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a link to the repo in a comment here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaekwon what do you prefer between:
- letting this external service dependency
- hosting an official one under the gno.land domain
- extending the
gnoland
server to support an additional REST endpoint here
I suggest 1 for now, and 3 as the target.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest: 'https://lcd.gno.tools', | |
rest: 'https://lcd.gno.tools', // https://github.com/disperze/gno-api |
should be this if I'm not wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that api is only for Keplr, but I think Keplr will only use the RPC in the future.
const gnoToken = { | ||
coinDenom: "GNOT", | ||
coinMinimalDenom: "gnot", | ||
coinDecimals: 6, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL :)
where is this number coming from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from ATOM, I'm not sure if Jae wants to change that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've finished a first round of reviews
Most of them are more about cosmetics and could be skipped and done later if there were an urge to merge it
About my question about CORS config, can we go with this: c := cors.New(cors.Options{
AllowedOrigins: []string{"*"},
AllowedMethods: []string{http.MethodGet, http.MethodPost},
AllowedHeaders: []string{"Content-Type", "Accept"},
}) |
it is only need to enable [rpc]
# TCP or UNIX socket address for the RPC server to listen on
laddr = "tcp://127.0.0.1:26657"
# A list of origins a cross-domain request can be executed from
# Default value '[]' disables cors support
# Use '["*"]' to allow any origin
cors_allowed_origins = ["*"] |
Wow, well done for the pb/rpc bridge Can you add the generate instructions in the Makefile? |
ok, i will add it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaekwon, from my POV -> LGTM.
Can you give a second look, and reply to the various questions, especially the one about lcd.gno.tools
?
FYI, we’ve added CORS headers on staging.gno.land and soon on test2.gno.land Can it allows you to remove your proxy? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just updating the PR status while we address the last details
this issue is necessary #275 |
With adena as the main wallet, this is obsolete. |
It still makes sense to add Gno support on Keplr. Feel free to reopen whenever it makes sense. |
Related w/ chainapsis/keplr-wallet#392
Depends on #275