Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gnoweb): Docs link to gnokey list with specific anchor #2428

Conversation

RezaRahemtola
Copy link
Member

In the realm help UI of gnoweb, a link to the documentation of gnokey list is provided, but it's only redirecting to the page and not the specific list explanation.

Fixed it by adding the corresponding anchor to the link.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.68%. Comparing base (28c3b1a) to head (0312470).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2428   +/-   ##
=======================================
  Coverage   54.68%   54.68%           
=======================================
  Files         583      583           
  Lines       78502    78502           
=======================================
  Hits        42927    42927           
  Misses      32367    32367           
  Partials     3208     3208           
Flag Coverage Δ
contribs/gnodev 23.81% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (ø)
contribs/gnokeykc 0.00% <ø> (ø)
contribs/gnomd 0.00% <ø> (ø)
gno.land 62.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leohhhn leohhhn merged commit 764eb65 into gnolang:master Jun 26, 2024
81 checks passed
@RezaRahemtola RezaRahemtola deleted the reza/gnoweb-specific-gnokey-list-docs-link branch June 26, 2024 10:11
gfanton pushed a commit to gfanton/gno that referenced this pull request Jul 23, 2024
…g#2428)

In the realm help UI of `gnoweb`, a link to the documentation of `gnokey
list` is provided, but it's only redirecting to the page and not the
specific `list` explanation.

Fixed it by adding the corresponding anchor to the link.

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants