Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest release is broken due to patch-package #153

Closed
compojoom opened this issue Jan 14, 2024 · 1 comment · Fixed by #154
Closed

Latest release is broken due to patch-package #153

compojoom opened this issue Jan 14, 2024 · 1 comment · Fixed by #154
Assignees
Labels
bug Something isn't working

Comments

@compojoom
Copy link
Contributor

compojoom commented Jan 14, 2024

Describe the bug
I guess I broke it :(

[4/4] 🔨  Building fresh packages...
⠁
⠁
⠁
error /node_modules/@gnosis.pm/zodiac: Command failed.
Exit code: 127
Command: patch-package
Arguments:
Directory: /node_modules/@gnosis.pm/zodiac

Adding patch-package at the post-install step was a mistake as yarn is trying to execute that step even when installing the package as a dependency. Maybe we should try moving it to generate types step which is called when trying to make a build, so no post install will be called when adding the package to other pojects.

To Reproduce
just try to yarn add the package

Expected behavior
To succeed.

Screenshots / logs
If applicable, add screenshots and/or logs to help explain your problem.

Relevant environment details:

  • OS: [e.g. iOS]
  • Browser [e.g. chrome 22, safari]
  • Node version [e.g. 14.17.4]
  • etc

Additional context
Add any other context about the problem here.

@compojoom
Copy link
Contributor Author

thanks @jfschwarz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants